Sign upLogin

jbox-web/redmine_git_hosting

View on GitHub
Star
app/models/concerns/gitolitable/validations.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method additional_constraints_on_identifier has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def additional_constraints_on_identifier
      if identifier.present? && (new_record? || identifier_changed?)
        errors.add :identifier, :cannot_equal_project if Project.find_by identifier: identifier

        # See if a repo for another project has the same identifier (existing validations already check for current project)
Severity: Minor
Found in app/models/concerns/gitolitable/validations.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method default_repository_has_identifier has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def default_repository_has_identifier
      return unless project && (is_default? || set_as_default?)

      possibles = Repository.where project_id: project.id
      possibles = possibles.where(identifier: nil).or(possibles.where(identifier: ''))
Severity: Minor
Found in app/models/concerns/gitolitable/validations.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status