Sign upLogin

jbox-web/redmine_git_hosting

View on GitHub
Star

Showing 72 of 72 total issues

Method entry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def entry(path = nil, identifier = nil)
          parts = path.to_s.split(%r{[/\\]}).select(&:present?)
          search_path = parts[0..-2].join('/')
          search_name = parts[-1]
          if search_path.blank? && search_name.blank?
Severity: Minor
Found in lib/redmine/scm/adapters/xitolite_adapter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_permissions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def build_permissions
      @permissions['RW+'][''] = gitolite_users[:rewind_users] unless no_users? :rewind_users
      @permissions['RW']['']  = gitolite_users[:write_users]  unless no_users? :write_users
      @permissions['R']['']   = gitolite_users[:read_users]   unless no_users? :read_users
    end
Severity: Minor
Found in app/services/permissions_builder/standard.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_deployment_credential has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def find_deployment_credential
    credential = @repository.deployment_credentials.find params[:id]
  rescue ActiveRecord::RecordNotFound
    render_404
  else
Severity: Minor
Found in app/controllers/repository_deployment_credentials_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method smart_http_enabled_for_download? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def smart_http_enabled_for_download?(repository, ssl: false)
      # SmartHTTP is disabled
      return false unless repository.smart_http_enabled?
      # HTTPS only but no SSL
      return false if repository.only_https_access_enabled? && !ssl
Severity: Minor
Found in lib/redmine_git_hosting/git_access.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method method_missing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def method_missing(method, *args, &block)
      return super(method, *args, &block) unless io_method? method

      # Shouldn't happen, but might be problem
      if @read_stream.nil?
Severity: Minor
Found in lib/redmine_git_hosting/shell_redirector.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_refspec has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def parse_refspec(spec)
        parsed_refspec = spec.match REF_COMPONENT_REGEX
        return if parsed_refspec.nil?

        if parsed_refspec[1]
Severity: Minor
Found in lib/redmine_git_hosting/utils/git.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method available_urls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def available_urls
      hash = {}
      hash[:ssh]       = ssh_access if ssh_access_available?
      hash[:https]     = https_access if https_access_available?
      hash[:http]      = http_access if http_access_available?
Severity: Minor
Found in app/models/concerns/gitolitable/urls.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_redmine_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def add_redmine_key
          # RedmineGitHosting key must be in RW+ group
          # If not create the RW+ group and add the key
          if perms.empty?
            logger.info "#{context} : No permissions set for '@all' repository, add RedmineGitHosting key"
Severity: Minor
Found in lib/redmine_git_hosting/gitolite_wrappers/global/enable_rw_access.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_reload_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def do_reload_config(default_hash)
        ## Refresh Settings cache
        Setting.check_cache

        ## Get actual values
Severity: Minor
Found in lib/redmine_git_hosting/config/base.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method install! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def install!
      if !file_exists?
        logger.info "Hook '#{name}' does not exist, installing it ..."
        install_hook
      elsif hook_file_has_changed?
Severity: Minor
Found in lib/redmine_git_hosting/gitolite_hook.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def create
    @post_receive_url = @repository.post_receive_urls.new
    @post_receive_url.safe_attributes = params[:repository_post_receive_url]
    return render action: 'new' unless @post_receive_url.save
Severity: Minor
Found in app/controllers/repository_post_receive_urls_controller.rb and 1 other location - About 15 mins to fix
app/controllers/repository_mirrors_controller.rb on lines 20..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def create
    @mirror = @repository.mirrors.new
    @mirror.safe_attributes = params[:repository_mirror]
    return render action: 'new' unless @mirror.save
Severity: Minor
Found in app/controllers/repository_mirrors_controller.rb and 1 other location - About 15 mins to fix
app/controllers/repository_post_receive_urls_controller.rb on lines 19..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language