Sign upLogin

jbox-web/redmine_git_hosting

View on GitHub
Star
lib/redmine_git_hosting/patches/repositories_controller_patch.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method diff_with_options has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

      def diff_with_options
        if params[:format] == 'diff'
          @diff = @repository.diff @path, @rev, @rev_to, bypass_cache: true
          return show_error_not_found unless @diff
Severity: Minor
Found in lib/redmine_git_hosting/patches/repositories_controller_patch.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_project_repository has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def find_project_repository
        @project = Project.find params[:id]
        @repository = if params[:repository_id].present?
                        @project.repositories.find_by_identifier_param params[:repository_id] # rubocop: disable Rails/DynamicFindBy
                      else
Severity: Minor
Found in lib/redmine_git_hosting/patches/repositories_controller_patch.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method diff_with_options has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def diff_with_options
        if params[:format] == 'diff'
          @diff = @repository.diff @path, @rev, @rev_to, bypass_cache: true
          return show_error_not_found unless @diff
Severity: Minor
Found in lib/redmine_git_hosting/patches/repositories_controller_patch.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status