Sign upLogin

jcbantuelle/dominion-meteor

View on GitHub
Star
app/cards/base/library.js

Summary

Maintainability
C
1 day
Test Coverage

Function play has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  play(game, player_cards) {
    if (_.size(player_cards.hand) >= 7) {
      game.log.push(`  but ${player_cards.username} already has 7 cards in hand`)
    } else {
      if (player_cards.tokens.minus_card) {
Severity: Minor
Found in app/cards/base/library.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function draw_cards has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  static draw_cards(game, player_cards) {
    if (_.size(player_cards.hand) >= 7 || (_.size(player_cards.deck) === 0 && _.size(player_cards.discard) === 0)) {
      if (_.size(player_cards.aside) > 0) {
        let card_discarder = new CardDiscarder(game, player_cards, 'aside')
        card_discarder.discard()
Severity: Minor
Found in app/cards/base/library.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function draw_cards has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static draw_cards(game, player_cards) {
    if (_.size(player_cards.hand) >= 7 || (_.size(player_cards.deck) === 0 && _.size(player_cards.discard) === 0)) {
      if (_.size(player_cards.aside) > 0) {
        let card_discarder = new CardDiscarder(game, player_cards, 'aside')
        card_discarder.discard()
Severity: Minor
Found in app/cards/base/library.js - About 1 hr to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

          if (_.includes(_.words(drawn_card.types), 'action')) {
        let turn_event_id = TurnEventModel.insert({
          game_id: game._id,
          player_id: player_cards.player_id,
          username: player_cards.username,
    Severity: Major
    Found in app/cards/base/library.js and 6 other locations - About 3 hrs to fix
    app/cards/adventures/wine_merchant.js on lines 26..38
    app/cards/cornucopia/tournament.js on lines 27..41
    app/cards/dark_ages/cultist.js on lines 21..33
    app/cards/promo/walled_village.js on lines 23..35
    app/cards/prosperity/mountebank.js on lines 28..42
    app/cards/seaside/explorer.js on lines 16..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            game.log.push(`  ${player_cards.username} draws up to ${_.size(player_cards.hand)} ${card_text} in hand`)
    Severity: Major
    Found in app/cards/base/library.js and 6 other locations - About 40 mins to fix
    app/cards/adventures/gear.js on lines 43..43
    app/cards/cornucopia/followers.js on lines 45..45
    app/cards/empires/archive.js on lines 20..20
    app/cards/menagerie/sleigh.js on lines 41..41
    app/cards/renaissance/research.js on lines 48..48
    app/game/server/services/deck_shuffler.js on lines 106..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 12 locations. Consider refactoring.
    Open

          if (_.size(player_cards.deck) === 0) {
        let deck_shuffler = new DeckShuffler(game, player_cards)
        deck_shuffler.shuffle()
      }
    Severity: Major
    Found in app/cards/base/library.js and 11 other locations - About 30 mins to fix
    app/cards/adventures/warrior.js on lines 26..29
    app/cards/base/vassal.js on lines 22..25
    app/cards/cornucopia/jester.js on lines 27..30
    app/cards/hinterlands/duchess.js on lines 31..34
    app/cards/hinterlands/jack_of_all_trades.js on lines 20..23
    app/cards/intrigue/swindler.js on lines 27..30
    app/cards/nocturne/hexes/locusts.js on lines 7..10
    app/cards/nocturne/zombie_mason.js on lines 15..18
    app/cards/seaside/native_village.js on lines 45..48
    app/cards/seaside/pearl_diver.js on lines 23..26
    app/cards/seaside/sea_hag.js on lines 20..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status