Sign upLogin

jchavarri/flywheeljs

View on GitHub
Star

Showing 7 of 7 total issues

Function build has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function build() {

  var source = gulp.src(path.join('src', 'index.js'))
    .pipe($.plumber());
Severity: Minor
Found in gulpfile.babel.js - About 1 hr to fix

    Function testBrowser has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function testBrowser() {
  // Our testing bundle is made up of our unit tests, which
  // should individually load up pieces of our application.
  // We also include the browser setup file.
  const testFiles = glob.sync('./test/unit/**/*.js');
    Severity: Minor
    Found in gulpfile.babel.js - About 1 hr to fix

      Function generateRideFunction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.generateRideFunction = function(name, description, flywheelFunction) {

  program
  .description(description)
  .option('-r, --rideId <rideId>', '[required] The ride id to request status for')
      Severity: Minor
      Found in examples/nodejs/generate-ride-function.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                city: googleData.address_components
          .filter((el) => el.types.indexOf('locality') !== -1)
          .reduce((prev, next) => next.long_name, '')
        Severity: Major
        Found in examples/nodejs/index-request.js and 2 other locations - About 1 hr to fix
        examples/nodejs/index-request.js on lines 43..45
        examples/nodejs/index-request.js on lines 46..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                country: googleData.address_components
          .filter((el) => el.types.indexOf('country') !== -1)
          .reduce((prev, next) => next.long_name, ''),
        Severity: Major
        Found in examples/nodejs/index-request.js and 2 other locations - About 1 hr to fix
        examples/nodejs/index-request.js on lines 43..45
        examples/nodejs/index-request.js on lines 49..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                state: googleData.address_components
          .filter((el) => el.types.indexOf('administrative_area_level_1') !== -1)
          .reduce((prev, next) => next.short_name, ''),
        Severity: Major
        Found in examples/nodejs/index-request.js and 2 other locations - About 1 hr to fix
        examples/nodejs/index-request.js on lines 46..48
        examples/nodejs/index-request.js on lines 49..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function generateRideFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.generateRideFunction = function(name, description, flywheelFunction) {

  program
  .description(description)
  .option('-r, --rideId <rideId>', '[required] The ride id to request status for')
        Severity: Minor
        Found in examples/nodejs/generate-ride-function.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language