Sign upLogin

jcready/http-as-promised

View on GitHub
Star

Showing 6 of 6 total issues

Function wrapRequest has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (function wrapRequest(request, defaultOpts){
  reqMethods.forEach(function (method){
    HTTP[method] = HTTP_METHODS.hasOwnProperty(method)
                 ? wrapMethod(HTTP_METHODS[method])
                 : request[method].bind(request);
Severity: Minor
Found in http.promise.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function wrapRequest has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function wrapRequest(request, defaultOpts){
  reqMethods.forEach(function (method){
    HTTP[method] = HTTP_METHODS.hasOwnProperty(method)
                 ? wrapMethod(HTTP_METHODS[method])
                 : request[method].bind(request);
Severity: Major
Found in http.promise.js - About 4 hrs to fix

    Function HTTP has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function HTTP(options, extra){
    var opts = setOptions(options, extra);
    opts.method = opts.method.toUpperCase();
    return new Promise(function HTTP_PROMISE(resolve, reject) {
      request(opts, function HTTP_RESPONSE(error, response, body) {
    Severity: Major
    Found in http.promise.js - About 2 hrs to fix

      Function HTTP_PROMISE has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          return new Promise(function HTTP_PROMISE(resolve, reject) {
      request(opts, function HTTP_RESPONSE(error, response, body) {
        if (error) {
          error.options = opts;
          error.statusCode = 0;
      Severity: Minor
      Found in http.promise.js - About 1 hr to fix

        Function HTTP_RESPONSE has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              request(opts, function HTTP_RESPONSE(error, response, body) {
        if (error) {
          error.options = opts;
          error.statusCode = 0;
          error.title = 'Invalid Request';
        Severity: Minor
        Found in http.promise.js - About 1 hr to fix

          Function assign has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function assign(target, extension){ /*eslint-disable curly*/
  if (typeof extension === 'object' && extension !== null)
    for (var k in extension)
      if (extension.hasOwnProperty(k))
        target[k] = extension[k];
          Severity: Minor
          Found in http.promise.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language