Sign upLogin

jdantonio/concurrent-ruby

View on GitHub
Star
examples/benchmark_read_write_lock.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method single_test has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

def single_test(lock, n_readers, n_writers, reader_iterations=50, writer_iterations=50, reader_sleep=0.001, writer_sleep=0.001)
  puts "Testing #{lock.class} with #{n_readers} readers and #{n_writers} writers. Readers iterate #{reader_iterations} times, sleeping #{reader_sleep}s each time, writers iterate #{writer_iterations} times, sleeping #{writer_sleep}s each time"
  mutex = Mutex.new
  bad   = false
  data  = 0
Severity: Minor
Found in examples/benchmark_read_write_lock.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method single_test has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def single_test(lock, n_readers, n_writers, reader_iterations=50, writer_iterations=50, reader_sleep=0.001, writer_sleep=0.001)
  puts "Testing #{lock.class} with #{n_readers} readers and #{n_writers} writers. Readers iterate #{reader_iterations} times, sleeping #{reader_sleep}s each time, writers iterate #{writer_iterations} times, sleeping #{writer_sleep}s each time"
  mutex = Mutex.new
  bad   = false
  data  = 0
Severity: Minor
Found in examples/benchmark_read_write_lock.rb - About 1 hr to fix

    Method single_test has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def single_test(lock, n_readers, n_writers, reader_iterations=50, writer_iterations=50, reader_sleep=0.001, writer_sleep=0.001)
    Severity: Major
    Found in examples/benchmark_read_write_lock.rb - About 50 mins to fix

      There are no issues that match your filters.

      Category
      Status