Sign upLogin

jekyll/jekyll-assets

View on GitHub
Star

Showing 38 of 38 total issues

Method vips_resize has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

        def vips_resize(img)
          resize_opts = {}
          if args[:vips][:resize].is_a? Integer
            width = args[:vips][:resize]
          else
Severity: Minor
Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module Jekyll
  module Assets
    class Default
      class Audio < Default
        content_types %r!^audio/[a-zA-Z0-9\-_]+$!
Severity: Major
Found in lib/jekyll/assets/plugins/html/defaults/audio.rb and 1 other location - About 2 hrs to fix
lib/jekyll/assets/plugins/html/defaults/vid.rb on lines 6..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module Jekyll
  module Assets
    class Default
      class Video < Default
        content_types %r!^video/.*$!
Severity: Major
Found in lib/jekyll/assets/plugins/html/defaults/vid.rb and 1 other location - About 2 hrs to fix
lib/jekyll/assets/plugins/html/defaults/audio.rb on lines 6..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method vips_resize has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def vips_resize(img)
          resize_opts = {}
          if args[:vips][:resize].is_a? Integer
            width = args[:vips][:resize]
          else
Severity: Major
Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 2 hrs to fix

    File utils.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Jekyll
  module Assets
    module Utils
      def self.activate(gem)
        spec = Gem::Specification
    Severity: Minor
    Found in lib/jekyll/assets/utils.rb - About 2 hrs to fix

      Method call has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

                def call(input)
            comp = input[:environment].asset_config[:compression]
            data = Crass.parse(input[:data] || "", preserve_comments: true)
            data.each do |v|
              next unless v[:node] == :style_rule
      Severity: Minor
      Found in lib/jekyll/assets/plugins/alternates.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prefix_url has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

            def prefix_url(user_path = nil)
        cfg, j_cfg = asset_config, jekyll.config
        cdn_url = make_https(strip_slashes(cfg[:cdn][:url]))
        base_url = jekyll.config.fetch("baseurl_root", j_cfg["baseurl"])
        destination = strip_slashes(cfg[:destination])
      Severity: Minor
      Found in lib/jekyll/assets/utils.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def process
          in_file = @file
          in_ext = in_file.extname

          img = ::Vips::Image.new_from_file in_file
      Severity: Minor
      Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 1 hr to fix

        Method process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

                def process
          in_file = @file
          in_ext = in_file.extname

          img = ::Vips::Image.new_from_file in_file
        Severity: Minor
        Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              Hook.register :asset, :after_compression, priority: 3 do |i, o, t|
        next o unless t == "text/css"

        env = i[:environment]
        asset = env.find_asset!(i[:filename], pipeline: :source)
        Severity: Major
        Found in lib/jekyll/assets/plugins/srcmap/css.rb and 1 other location - About 1 hr to fix
        lib/jekyll/assets/plugins/srcmap/javascript.rb on lines 9..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              Hook.register :asset, :after_compression, priority: 3 do |i, o, t|
        next o unless t == "application/javascript"

        env = i[:environment]
        asset = env.find_asset!(i[:filename], pipeline: :source)
        Severity: Major
        Found in lib/jekyll/assets/plugins/srcmap/javascript.rb and 1 other location - About 1 hr to fix
        lib/jekyll/assets/plugins/srcmap/css.rb on lines 9..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method manifest_files has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

              def manifest_files(env)
        manifest = env.manifest.data.values_at(*Manifest.keep_keys).map(&:to_a)
        out = manifest.flatten.each_with_object([]) do |v, a|
          path = Pathutil.new(env.in_dest_dir(v))
          a << path.to_s + ".gz" if path.exist? && !env.skip_gzip?
        Severity: Minor
        Found in lib/jekyll/assets/utils.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method prefix_url has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def prefix_url(user_path = nil)
        cfg, j_cfg = asset_config, jekyll.config
        cdn_url = make_https(strip_slashes(cfg[:cdn][:url]))
        base_url = jekyll.config.fetch("baseurl_root", j_cfg["baseurl"])
        destination = strip_slashes(cfg[:destination])
        Severity: Minor
        Found in lib/jekyll/assets/utils.rb - About 1 hr to fix

          Method development has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def self.development
        return @development if defined?(@development)
        @development = {
          digest: true,
          precompile: [],
          Severity: Minor
          Found in lib/jekyll/assets/config.rb - About 1 hr to fix

            Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                    def run
          if asset.is_a?(Url) && args[:inline]
            raise Tag::MixedArg, "@external", "@inline"

          else
            Severity: Minor
            Found in lib/jekyll/assets/plugins/html/js.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def render(ctx)
        env = ctx.registers[:site].sprockets
        args, asset = render_raw(
          ctx
        )
            Severity: Minor
            Found in lib/jekyll/assets/tag.rb - About 1 hr to fix

              Method process has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                      def process
          img = ::MiniMagick::Image.new(@file)
          magick_format(img) if args[:magick][:format]
          img.combine_options do |c|
            args[:magick].keys.reject { |k| k == :format }.each do |k|
              Severity: Minor
              Found in lib/jekyll/assets/plugins/proxy/magick.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method raw_precompiles has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def raw_precompiles
        asset_config[:raw_precompile].each_with_object([]) do |h, a|
          h = { source: h } unless h.is_a?(Hash)
          r = Regexp.new(h[:strip]) if h.key?(:strip)
          s = h.fetch(:source) { h.fetch(:src) }
              Severity: Minor
              Found in lib/jekyll/assets/utils.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method proxy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def self.proxy(asset, args:, ctx:)
        env = ctx.registers[:site].sprockets
        return asset if (proxies = proxies_for(asset: asset, args: args)).empty?
        key = digest(args)
              Severity: Minor
              Found in lib/jekyll/assets/proxy.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run
          Nokogiri::HTML::Builder.with(doc) do |html|
            next automatic(html) if responsive? && automatic?
            next discovery(html) if responsive? && discovery?
            build_img(
              Severity: Minor
              Found in lib/jekyll/assets/plugins/html/img.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language