Sign upLogin

jekyll/jekyll-assets

View on GitHub
Star

Showing 23 of 38 total issues

Method vips_resize has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

        def vips_resize(img)
          resize_opts = {}
          if args[:vips][:resize].is_a? Integer
            width = args[:vips][:resize]
          else
Severity: Minor
Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method vips_resize has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def vips_resize(img)
          resize_opts = {}
          if args[:vips][:resize].is_a? Integer
            width = args[:vips][:resize]
          else
Severity: Major
Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 2 hrs to fix

    File utils.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Jekyll
  module Assets
    module Utils
      def self.activate(gem)
        spec = Gem::Specification
    Severity: Minor
    Found in lib/jekyll/assets/utils.rb - About 2 hrs to fix

      Method call has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

                def call(input)
            comp = input[:environment].asset_config[:compression]
            data = Crass.parse(input[:data] || "", preserve_comments: true)
            data.each do |v|
              next unless v[:node] == :style_rule
      Severity: Minor
      Found in lib/jekyll/assets/plugins/alternates.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prefix_url has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

            def prefix_url(user_path = nil)
        cfg, j_cfg = asset_config, jekyll.config
        cdn_url = make_https(strip_slashes(cfg[:cdn][:url]))
        base_url = jekyll.config.fetch("baseurl_root", j_cfg["baseurl"])
        destination = strip_slashes(cfg[:destination])
      Severity: Minor
      Found in lib/jekyll/assets/utils.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def process
          in_file = @file
          in_ext = in_file.extname

          img = ::Vips::Image.new_from_file in_file
      Severity: Minor
      Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 1 hr to fix

        Method process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

                def process
          in_file = @file
          in_ext = in_file.extname

          img = ::Vips::Image.new_from_file in_file
        Severity: Minor
        Found in lib/jekyll/assets/plugins/proxy/vips.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method manifest_files has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

              def manifest_files(env)
        manifest = env.manifest.data.values_at(*Manifest.keep_keys).map(&:to_a)
        out = manifest.flatten.each_with_object([]) do |v, a|
          path = Pathutil.new(env.in_dest_dir(v))
          a << path.to_s + ".gz" if path.exist? && !env.skip_gzip?
        Severity: Minor
        Found in lib/jekyll/assets/utils.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method prefix_url has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def prefix_url(user_path = nil)
        cfg, j_cfg = asset_config, jekyll.config
        cdn_url = make_https(strip_slashes(cfg[:cdn][:url]))
        base_url = jekyll.config.fetch("baseurl_root", j_cfg["baseurl"])
        destination = strip_slashes(cfg[:destination])
        Severity: Minor
        Found in lib/jekyll/assets/utils.rb - About 1 hr to fix

          Method development has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def self.development
        return @development if defined?(@development)
        @development = {
          digest: true,
          precompile: [],
          Severity: Minor
          Found in lib/jekyll/assets/config.rb - About 1 hr to fix

            Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                    def run
          if asset.is_a?(Url) && args[:inline]
            raise Tag::MixedArg, "@external", "@inline"

          else
            Severity: Minor
            Found in lib/jekyll/assets/plugins/html/js.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def render(ctx)
        env = ctx.registers[:site].sprockets
        args, asset = render_raw(
          ctx
        )
            Severity: Minor
            Found in lib/jekyll/assets/tag.rb - About 1 hr to fix

              Method process has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                      def process
          img = ::MiniMagick::Image.new(@file)
          magick_format(img) if args[:magick][:format]
          img.combine_options do |c|
            args[:magick].keys.reject { |k| k == :format }.each do |k|
              Severity: Minor
              Found in lib/jekyll/assets/plugins/proxy/magick.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method raw_precompiles has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def raw_precompiles
        asset_config[:raw_precompile].each_with_object([]) do |h, a|
          h = { source: h } unless h.is_a?(Hash)
          r = Regexp.new(h[:strip]) if h.key?(:strip)
          s = h.fetch(:source) { h.fetch(:src) }
              Severity: Minor
              Found in lib/jekyll/assets/utils.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method proxy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def self.proxy(asset, args:, ctx:)
        env = ctx.registers[:site].sprockets
        return asset if (proxies = proxies_for(asset: asset, args: args)).empty?
        key = digest(args)
              Severity: Minor
              Found in lib/jekyll/assets/proxy.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run
          Nokogiri::HTML::Builder.with(doc) do |html|
            next automatic(html) if responsive? && automatic?
            next discovery(html) if responsive? && discovery?
            build_img(
              Severity: Minor
              Found in lib/jekyll/assets/plugins/html/img.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method set_static has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def self.set_static(args, asset:)
        get(type: asset.content_type, args: args).each do |k, v|
          k = k.to_sym

          unless args.key?(k)
              Severity: Minor
              Found in lib/jekyll/assets/default.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method setup_sources! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def setup_sources!
        source_dir, cwd = Pathutil.new(jekyll.in_source_dir), Pathutil.cwd
        asset_config['sources'].each do |v|
          path = source_dir.join(v).expand_path
          next unless path.in_path?(cwd)
              Severity: Minor
              Found in lib/jekyll/assets/env.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method to_liquid_payload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def to_liquid_payload
        each_file&.each_with_object({}) do |k, h|
          skip, path = false, Pathutil.new(strip_paths(k))
          path.descend do |p|
            skip = p.start_with?('_')
              Severity: Minor
              Found in lib/jekyll/assets/env.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run
          html.search("img[@asset]").each do |v|
            raise ArgumentError, "src is empty" unless v[:src]
            args = "#{v.delete('src')&.value} #{v.delete('asset')&.value}"
            pctx = ::Liquid::ParseContext.new
              Severity: Minor
              Found in lib/jekyll/assets/plugins/searcher.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language