Sign upLogin

jelhan/croodle

View on GitHub
Star

Showing 31 of 31 total issues

Function createPoll has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  @action
  async createPoll() {
    const { poll } = this.args;
    const {
      anonymousUser,
Severity: Major
Found in app/components/create-settings.ts - About 2 hrs to fix

    Function bestOptions has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      get bestOptions(): BestOption[] | null {
    const { poll } = this.args;
    const { isFreeText, options, users } = poll;

    // can not evaluate answer type free text
    Severity: Major
    Found in app/components/poll-evaluation-summary.ts - About 2 hrs to fix

      Function load has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static async load(id: string, passphrase: string) {
    const url = apiUrl(`polls/${id}`);

    // TODO: Handle network connectivity error
    const response = await fetch(url);
      Severity: Major
      Found in app/models/poll.ts - About 2 hrs to fix

        Function save has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

          public function save() {
    // create dir for data if it does not exists
    $counter = 0;
    while (true) {
      $this->set('id', $this->generateNewId());
        Severity: Minor
        Found in api/classes/model.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          @action
  previousPage() {
    const { pollType } = this.args.poll;

    if (pollType === 'FindADate') {
        Severity: Major
        Found in app/components/create-settings.ts and 1 other location - About 2 hrs to fix
        app/components/create-options.ts on lines 124..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          @action
  submit() {
    const { pollType } = this.args.poll;

    if (pollType === 'FindADate') {
        Severity: Major
        Found in app/components/create-options.ts and 1 other location - About 2 hrs to fix
        app/components/create-settings.ts on lines 90..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function normalize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          normalize(payload) {
    let [type] = Object.keys(payload);
    let attrs = payload[type];
    let { belongsToAssociations, hasManyAssociations } =
      this.registry.schema._registry[type].class.prototype;
        Severity: Major
        Found in mirage/serializers/application.js - About 2 hrs to fix

          Function create has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            static async create(
    {
      anonymousUser,
      answerType,
      description,
          Severity: Major
          Found in app/models/poll.ts - About 2 hrs to fix

            Function exports has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function (defaults) {
  const app = new EmberApp(defaults, {
    buildInfoOptions: {
      metaTemplate: 'version={SEMVER}',
    },
            Severity: Minor
            Found in ember-cli-build.js - About 1 hr to fix

              Function createPoll has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                @action
  async createPoll() {
    const { poll } = this.args;
    const {
      anonymousUser,
              Severity: Minor
              Found in app/components/create-settings.ts - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method restore has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public static function restore($id) {
    if (!static::isValidId($id)) {
      throw new Exception($id . ' is not a valid id');
    }
              Severity: Minor
              Found in api/classes/model.php - About 1 hr to fix

                Function postBuild has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  postBuild(result) {
    let environment = this.app.env;

    // do not include app if build is for testing purposes only
    if (environment === 'test') {
                Severity: Minor
                Found in lib/include-api-in-build/index.js - About 1 hr to fix

                  Function default has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export default function (
  answerType: 'YesNo' | 'YesNoMaybe' | 'FreeText',
): Answer[] {
  switch (answerType) {
    case 'YesNo':
                  Severity: Minor
                  Found in app/utils/answers-for-answer-type.ts - About 1 hr to fix

                    Method save has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      public function save() {
    // create dir for data if it does not exists
    $counter = 0;
    while (true) {
      $this->set('id', $this->generateNewId());
                    Severity: Minor
                    Found in api/classes/model.php - About 1 hr to fix

                      Function isValidSJCL has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                        private static function isValidSJCL($jsonstring) {
    $accepted_keys=array('iv','v','iter','ks','ts','mode','adata','cipher','salt','ct');

    // Make sure content is valid json
    $decoded = json_decode($jsonstring);
                      Severity: Minor
                      Found in api/classes/model.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function submit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        @action
  async submit() {
    const { formData, poll } = this.model;
    const { name } = formData;
    const { answers, isFreeText } = poll;
                      Severity: Minor
                      Found in app/controllers/poll/participation.ts - About 1 hr to fix

                        Function deleteDirRecursively has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                          private function deleteDirRecursively($dir) {
    if (substr($dir, -1) !== '/') {
      throw new Exception('dir has to end on /');
    }
                        Severity: Minor
                        Found in api/classes/poll.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function restore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                          public static function restore($id) {
    if (!static::isValidId($id)) {
      throw new Exception($id . ' is not a valid id');
    }
                        Severity: Minor
                        Found in api/classes/model.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                          public static function create($data) {
    if (!is_object($data)) {
      throw new Exception('data must be an object');
    }
                        Severity: Minor
                        Found in api/classes/model.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function getUsers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                          protected function getUsers() {
    $users = [];

    $userDir = DATA_FOLDER . $this->get('id') . '/user/';
    if (is_dir($userDir)) {
                        Severity: Minor
                        Found in api/classes/poll.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language