Showing 22 of 28 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
import Foundation
/**
Type that matchies a `URL` based on evaluation of its wrapped `URLMatchable`s, logically OR’d together.- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 117.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public enum Size: LocalizedError {
/// Error received when a given string domains too many characters to be used as a domain name.
case tooLong(String)
public var errorDescription: String? {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 54.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public enum Format: LocalizedError {
/// Error received when a given string contains characters which are disallowed in a domain name.
case invalid(String)
public var errorDescription: String? {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 54.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Force tries should be avoided. Open
public static let ftp = try! Scheme("ftp")- Exclude checks
Operators should be surrounded by a single whitespace when defining them. Open
public func ~=(pattern: URLMatchable, value: URL) -> Bool {- Exclude checks
Prefer checking isEmpty over comparing string to an empty string literal. Open
return url.path == ""- Exclude checks
Three lines between top-level items. Open
import Foundation- Exclude checks
Three lines between top-level items. Open
// swift-tools-version:4.0- Exclude checks
Force tries should be avoided. Open
public static let http = try! Scheme("http")- Exclude checks
Force tries should be avoided. Open
public static let file = try! Scheme("file")- Exclude checks
Files should have a single trailing newline. Open
- Exclude checks
Force tries should be avoided. Open
public static let sms = try! Scheme("sms")- Exclude checks
Force tries should be avoided. Open
public static let mailto = try! Scheme("mailto")- Exclude checks
Three lines between top-level items. Open
import Foundation- Exclude checks
Force tries should be avoided. Open
public static let webcal = try! Scheme("webcal")- Exclude checks
Force tries should be avoided. Open
public static let telprompt = try! Scheme("telprompt")- Exclude checks
Three lines between top-level items. Open
import PackageDescription- Exclude checks
Top-level declarations should specify Access Control Level keywords explicitly. Open
let package = Package(- Exclude checks
Force tries should be avoided. Open
public static let tel = try! Scheme("tel")- Exclude checks
There must be two or zero lines between second-level items. Open
private static let validCharacters: Set<Character> = validFirstCharacters.union(["+", "-", ".", "1", "2", "3", "4", "5", "6", "7", "8", "9", "0"])- Exclude checks