jenkinsci/hpe-application-automation-tools-plugin

View on GitHub
HpToolsLauncher/Utils/Helper.cs

Summary

Maintainability
B
4 hrs
Test Coverage

Avoid too many return statements within this method.
Open

            return true;
Severity: Major
Found in HpToolsLauncher/Utils/Helper.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return ans;
    Severity: Major
    Found in HpToolsLauncher/Utils/Helper.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return null;
      Severity: Major
      Found in HpToolsLauncher/Utils/Helper.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return TestState.Passed;
        Severity: Major
        Found in HpToolsLauncher/Utils/Helper.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return TestState.Unknown;
          Severity: Major
          Found in HpToolsLauncher/Utils/Helper.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return runDesc.TestState;
            Severity: Major
            Found in HpToolsLauncher/Utils/Helper.cs - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  {
                                      desc = string.Format(Resources.LrSLARuleFailed, node.Attributes["FullName"].Value,
                                          node.Attributes["GoalValue"].Value, node.Attributes["ActualValue"].Value);
                                      ConsoleWriter.WriteLine(desc);
                                  }
              Severity: Minor
              Found in HpToolsLauncher/Utils/Helper.cs and 1 other location - About 50 mins to fix
              HpToolsLauncher/Utils/Helper.cs on lines 1053..1057

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  {
                                      desc = string.Format(Resources.LrSLARuleFailed, node.Attributes["FullName"].Value,
                                          node.Attributes["GoalValue"].Value, node.Attributes["ActualValue"].Value);
                                      ConsoleWriter.WriteLine(desc);
                                  }
              Severity: Minor
              Found in HpToolsLauncher/Utils/Helper.cs and 1 other location - About 50 mins to fix
              HpToolsLauncher/Utils/Helper.cs on lines 1034..1038

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status