Sign upLogin

jenkinsci/hpe-application-automation-tools-plugin

View on GitHub
Star
src/main/java/com/microfocus/application/automation/tools/pipelineSteps/SseBuildAndPublishStep.java

Summary

Maintainability
B
5 hrs
Test Coverage

Avoid too many return statements within this method.
Open

            return FormValidation.warning("Cannot find any credentials with id " + value);
Severity: Major
Found in src/main/java/com/microfocus/application/automation/tools/pipelineSteps/SseBuildAndPublishStep.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return FormValidation.ok();
    Severity: Major
    Found in src/main/java/com/microfocus/application/automation/tools/pipelineSteps/SseBuildAndPublishStep.java - About 30 mins to fix

      Constructor has 9 parameters, which is greater than 7 authorized.
      Open

          public SseBuildAndPublishStep(String almServerName,
      Severity: Major
      Found in src/main/java/com/microfocus/application/automation/tools/pipelineSteps/SseBuildAndPublishStep.java by sonar-java

      A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

      Noncompliant Code Example

      With a maximum number of 4 parameters:

      public void doSomething(int param1, int param2, int param3, String param4, long param5) {
...
}

      Compliant Solution

      public void doSomething(int param1, int param2, int param3, String param4) {
...
}

      Exceptions

      Methods annotated with :

      • Spring's @RequestMapping (and related shortcut annotations, like @GetRequest)
      • JAX-RS API annotations (like @javax.ws.rs.GET)
      • Bean constructor injection with @org.springframework.beans.factory.annotation.Autowired
      • CDI constructor injection with @javax.inject.Inject
      • @com.fasterxml.jackson.annotation.JsonCreator

      may have a lot of parameters, encapsulation being possible. Such methods are therefore ignored.

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              public FormValidation doCheckCredentialsId(@AncestorInPath Item project,
                                                   @QueryParameter String url,
                                                   @QueryParameter String value) {
            if (project == null || !project.hasPermission(Item.EXTENDED_READ)) {
                return FormValidation.ok();
      Severity: Major
      Found in src/main/java/com/microfocus/application/automation/tools/pipelineSteps/SseBuildAndPublishStep.java and 1 other location - About 2 hrs to fix
      src/main/java/com/microfocus/application/automation/tools/run/SseBuilder.java on lines 514..552

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 186.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

              public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item project,
                                                     @QueryParameter String credentialsId) {

            if (project == null || !project.hasPermission(Item.CONFIGURE)) {
                return new StandardUsernameListBoxModel().includeCurrentValue(credentialsId);
      Severity: Major
      Found in src/main/java/com/microfocus/application/automation/tools/pipelineSteps/SseBuildAndPublishStep.java and 4 other locations - About 1 hr to fix
      src/main/java/com/microfocus/application/automation/tools/commonResultUpload/CommonResultUploadBuilder.java on lines 243..256
      src/main/java/com/microfocus/application/automation/tools/results/TestResultToALMUploader.java on lines 524..537
      src/main/java/com/microfocus/application/automation/tools/run/PcBuilder.java on lines 1248..1262
      src/main/java/com/microfocus/application/automation/tools/run/SseBuilder.java on lines 498..512

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status