src/main/java/com/microfocus/application/automation/tools/run/MigrateAlmCredentialsBuilder.java
Avoid deeply nested control flow statements. Open
Open
if(!StringUtils.isNullOrEmpty(almUsername) || !StringUtils.isNullOrEmpty(almClientID)) {
listener.getLogger().println("Migrating credentials from task " + job.getDisplayName());
for (AlmServerSettingsModel model : models) {
if (model.getAlmServerName().equals(almBuilder.getAlmServerName())) {Refactor this method to reduce its Cognitive Complexity from 55 to the 15 allowed. Open
Open
public static void scanJobs(TaskListener listener) {- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.
See
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. Open
Open
public MigrateAlmCredentialsBuilder() {}- Read upRead up
- Exclude checks
There are several reasons for a method not to have a method body:
- It is an unintentional omission, and should be fixed to prevent an unexpected behavior in production.
- It is not yet, or never will be, supported. In this case an
UnsupportedOperationExceptionshould be thrown. - The method is an intentionally-blank override. In this case a nested comment should explain the reason for the blank override.
Noncompliant Code Example
public void doSomething() {
}
public void doSomethingElse() {
}
Compliant Solution
@Override
public void doSomething() {
// Do nothing because of X and Y.
}
@Override
public void doSomethingElse() {
throw new UnsupportedOperationException();
}
Exceptions
Default (no-argument) constructors are ignored when there are other constructors in the class, as are empty methods in abstract classes.
public abstract class Animal {
void speak() { // default implementation ignored
}
}