src/main/java/com/microfocus/application/automation/tools/run/UploadAppBuilder.java
Avoid too many return statements within this method. Open
Open
return false;Avoid too many return statements within this method. Open
Open
return allSuccess;Method has 11 parameters, which is greater than 7 authorized. Open
Open
public JSONArray getValidWorkspaces(String mcUrl, String authType, String mcUserName, String mcPassword, String mcTenantId, String mcExecToken,- Read upRead up
- Exclude checks
A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.
Noncompliant Code Example
With a maximum number of 4 parameters:
public void doSomething(int param1, int param2, int param3, String param4, long param5) {
...
}
Compliant Solution
public void doSomething(int param1, int param2, int param3, String param4) {
...
}
Exceptions
Methods annotated with :
- Spring's
@RequestMapping(and related shortcut annotations, like@GetRequest) - JAX-RS API annotations (like
@javax.ws.rs.GET) - Bean constructor injection with
@org.springframework.beans.factory.annotation.Autowired - CDI constructor injection with
@javax.inject.Inject -
@com.fasterxml.jackson.annotation.JsonCreator
may have a lot of parameters, encapsulation being possible. Such methods are therefore ignored.
Refactor this method to reduce its Cognitive Complexity from 69 to the 15 allowed. Open
Open
public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListener listener)- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.