Sign upLogin

jenkinsci/hpe-application-automation-tools-plugin

View on GitHub
Star
src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

            return FormValidation.error("Error opening a connection to the ALM server");
Severity: Major
Found in src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return FormValidation.ok();
    Severity: Major
    Found in src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java - About 30 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (ssoCredentialsObj instanceof JSONArray) {
                JSONArray ssoCredentialsObjArray = (JSONArray) ssoCredentialsObj;
                ssoCredentials = req.bindJSONToList(SSOCredentialsModel.class, ssoCredentialsObjArray);
            } else if (ssoCredentialsObj instanceof JSONObject) {
                SSOCredentialsModel ssoCredentialsModel = req.bindJSON(SSOCredentialsModel.class, (JSONObject) ssoCredentialsObj);
      Severity: Minor
      Found in src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java and 1 other location - About 55 mins to fix
      src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java on lines 98..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (credentialsObj instanceof JSONArray) {
                JSONArray credentialsObjArray = (JSONArray) credentialsObj;
                credentials = req.bindJSONToList(CredentialsModel.class, credentialsObjArray);
            } else if (credentialsObj instanceof JSONObject) {
                CredentialsModel credentialsModel = req.bindJSON(CredentialsModel.class, (JSONObject) credentialsObj);
      Severity: Minor
      Found in src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java and 1 other location - About 55 mins to fix
      src/main/java/com/microfocus/application/automation/tools/settings/AlmServerSettingsGlobalConfiguration.java on lines 108..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status