jeremytregunna/ruby-trello

View on GitHub

Showing 28 of 28 total issues

Function performSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function performSearch(data, regexps, queries, highlighters, state) {
Severity: Minor
Found in doc/js/searcher.js - About 35 mins to fix

    Method parse_json has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse_json(data, encoding = 'UTF-8')
            # Trello.http_client.parse_json(data, encoding)
            case data
            when Trello::Response
              JSON.parse(data.body.force_encoding(encoding))
    Severity: Minor
    Found in lib/trello/json_utils.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hookSearch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function hookSearch() {
      var input  = document.querySelector('#search-field');
      var result = document.querySelector('#search-results');
      result.classList.remove("initially-hidden");
    
    
    Severity: Minor
    Found in doc/js/darkfish.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_payload_for_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def build_payload_for_create(attributes, payload)
              payload ||= {}
              return payload unless for_action?(:create)
              return payload unless attributes.key?(name)
    
    
    Severity: Minor
    Found in lib/trello/schema/attribute/board_pref.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_payload_for_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def build_payload_for_create(attributes, payload)
              payload ||= {}
              return payload unless for_action?(:create)
              return payload unless attributes.key?(name)
    
    
    Severity: Minor
    Found in lib/trello/schema/attribute/custom_field_display.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_payload_for_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def build_payload_for_create(attributes, payload)
              payload ||= {}
              return payload unless for_action?(:create)
              return payload unless attributes.key?(name)
    
    
    Severity: Minor
    Found in lib/trello/schema/attribute/default.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method invoke_verb has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def invoke_verb(name, uri, body = nil)
          request = Request.new name, uri, {}, body
          response = TInternet.execute auth_policy.authorize(request)
    
          return '' unless response
    Severity: Minor
    Found in lib/trello/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method authorize_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.authorize_url(options = {})
        params = options.dup
        params[:key] ||= configuration.developer_public_key or
          raise ArgumentError, 'Please configure your Trello public key'
        params[:name] ||= 'Ruby Trello'
    Severity: Minor
    Found in lib/trello.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language