jerrywdlee/yaml_2_resume

View on GitHub

Showing 11 of 11 total issues

File cv_maker.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "mini_magick"
require "open-uri"
require "prawn"
require "wareki"
require "yaml"
Severity: Minor
Found in lib/cv_maker.rb - About 2 hrs to fix

    Method convert has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def convert(style_txt)
        data = []
        style_txt.lines.each do |line|
          next if line =~ /^#/
          next if line.chomp == ""
    Severity: Minor
    Found in lib/txt2yaml.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method education_experience has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def education_experience(h)
        y = size(h["y"])
        year_x = size(h["year_x"])
        month_x = size(h["month_x"])
        value_x = size(h["value_x"])
    Severity: Minor
    Found in lib/cv_maker.rb - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          education.each do |i|
            year = i.fetch("year", "").to_s
            month = i.fetch("month", "").to_s
            put_string(year_x, y, year, font_size, font_face)
            x = month_x - (month.size - 1) * font_size * 0.3
      Severity: Major
      Found in lib/cv_maker.rb and 2 other locations - About 1 hr to fix
      lib/cv_maker.rb on lines 211..218
      lib/cv_maker.rb on lines 237..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          experience.each do |i|
            year = i.fetch("year", "").to_s
            month = i.fetch("month", "").to_s
            put_string(year_x, y, year, font_size, font_face)
            x = month_x - (month.size - 1) * font_size * 0.3
      Severity: Major
      Found in lib/cv_maker.rb and 2 other locations - About 1 hr to fix
      lib/cv_maker.rb on lines 199..206
      lib/cv_maker.rb on lines 237..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          data.each do |i|
            year = i.fetch("year", "").to_s
            month = i.fetch("month", "").to_s
            put_string(year_x, y, year, font_size, font_face)
            x = month_x - (month.size - 1) * font_size * 0.3
      Severity: Major
      Found in lib/cv_maker.rb and 2 other locations - About 1 hr to fix
      lib/cv_maker.rb on lines 199..206
      lib/cv_maker.rb on lines 211..218

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      def box(h)
        a = []
        a.push h.delete("type")
        a.push h.delete("x")
        a.push h.delete("y")
      Severity: Minor
      Found in yaml2txt.rb and 1 other location - About 55 mins to fix
      yaml2txt.rb on lines 34..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      def line(h)
        a = []
        a.push h.delete("type")
        a.push h.delete("x")
        a.push h.delete("y")
      Severity: Minor
      Found in yaml2txt.rb and 1 other location - About 55 mins to fix
      yaml2txt.rb on lines 13..21

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method lines has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def lines(h)
          line_style(h)
          points = h["points"]
          x = size(points[0]["x"])
          y = size(points[0]["y"])
      Severity: Minor
      Found in lib/cv_maker.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method put_string has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def put_string(x, y, str, font_size, font_face)
      Severity: Minor
      Found in lib/cv_maker.rb - About 35 mins to fix

        Method line_style has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def line_style(h)
            if h.has_key?("line_style")
              case h["line_style"]
              when "solid"
                undash
        Severity: Minor
        Found in lib/cv_maker.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language