Sign upLogin

jeyroik/extas-conditions

View on GitHub
Star

Showing 4 of 4 total issues

Missing class import via use statement (line '37', column '19').
Open

        throw new \Exception('Need array as argument in a condition');
Severity: Minor
Found in src/components/conditions/ConditionAnd.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

End of line character is invalid; expected "\n" but found "\r\n"
Open

<?php
Severity: Minor
Found in extas.storage.php by phpcodesniffer

Rename this constant "FIELD__CONDITION" to match the regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$.
Open

    public const FIELD__CONDITION = 'condition';
Severity: Critical
Found in src/interfaces/conditions/IHasCondition.php by sonar-php

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

define("const1", true);

class Foo {
    const const2 = "bar";
}

Compliant Solution

define("CONST1", true);

class Foo {
    const CONST2 = "bar";
}

Define and throw a dedicated exception instead of using a generic one.
Open

        throw new \Exception('Need array as argument in a condition');
Severity: Major
Found in src/components/conditions/ConditionAnd.php by sonar-php

If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

Noncompliant Code Example

throw new Exception();  // Noncompliant

Compliant Solution

throw new InvalidArgumentException();
// or
throw new UnexpectedValueException();

See

Severity
Category
Status
Source
Language