jf647/acromine

View on GitHub

Showing 4 of 4 total issues

Method build_sort_xforms has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def build_sort_xforms(sort_spec)
    xforms = []
    sort_spec.split(',').each do |spec|
      what, how = spec.chars
      xforms << case what
Severity: Minor
Found in lib/acromine/core.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_opts has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_opts(limit: nil, sort_spec: nil)
    # validate that the limit is a positive integer
    if limit
      begin
        !Float(limit).nil?
Severity: Minor
Found in lib/acromine/core.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize
      # info about the CLI
      program_desc 'a client for the Acromine REST Service'
      version Acromine::VERSION
      config_file '.acromine.conf'
Severity: Minor
Found in lib/acromine/cli.rb - About 1 hr to fix

    Method build_sort_xforms has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def build_sort_xforms(sort_spec)
        xforms = []
        sort_spec.split(',').each do |spec|
          what, how = spec.chars
          xforms << case what
    Severity: Minor
    Found in lib/acromine/core.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language