jfilter/frag-den-staat-app

View on GitHub

Showing 110 of 110 total issues

Function navigationOptions has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

FoiRequestsWebView.navigationOptions = props => {
  const url = props.navigation.state.params.uri;

  function share() {
    Share.share(
Severity: Minor
Found in src/components/foiRequests/WebView/index.js - About 1 hr to fix

    Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
        const size = Platform.OS === 'ios' ? 35 : 26; // for icon
        const { search } = this.state;
        return (
          <View style={styles.background} keyboardShouldPersistTaps="handled">
    Severity: Minor
    Found in src/containers/search/SearchStartScreen.js - About 1 hr to fix

      Function navigationOptions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      PdfViewer.navigationOptions = props => {
        const { url } = props.navigation.state.params;
      
        function share() {
          Share.share(
      Severity: Minor
      Found in src/components/screens/PdfViewer/index.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <ListItem
                  containerStyle={styles.listItemContainer}
                  title={I18n.t('moreScreen.dataUse')}
                  leftIcon={{
                    color: greyDark,
        Severity: Major
        Found in src/containers/profile/ProfileStartScreen.js and 1 other location - About 1 hr to fix
        src/containers/profile/ProfileStartScreen.js on lines 134..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <ListItem
                  containerStyle={styles.listItemContainer}
                  title={I18n.t('moreScreen.tos')}
                  leftIcon={{
                    color: greyDark,
        Severity: Major
        Found in src/containers/profile/ProfileStartScreen.js and 1 other location - About 1 hr to fix
        src/containers/profile/ProfileStartScreen.js on lines 124..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function render has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
            const {
              navigateToPdfViewer,
              navigateToPublicBody,
              isPending,
        Severity: Minor
        Found in src/containers/foiRequests/FoiRequestsSingleScreen.js - About 1 hr to fix

          Function render has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render() {
              const {
                isPending,
                error,
                publicBody,
          Severity: Minor
          Found in src/containers/foiRequests/FoiRequestsPublicBodyScreen.js - About 1 hr to fix

            Function getCurrentAccessTokenOrRefresh has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const getCurrentAccessTokenOrRefresh = (dispatch, getState) => {
              return new Promise(async (resolve, reject) => {
                const {
                  timeStamp,
                  expiresIn,
            Severity: Minor
            Found in src/utils/oauth.js - About 1 hr to fix

              Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                render() {
                  const { filterUser, currentUserId, filterFollower } = this.props;
                  let secondIcon = null;
              
                  if (filterUser != null) {
              Severity: Minor
              Found in src/containers/foiRequests/FoiRequestsMasterScreen.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                SearchResultsFoiRequestsMasterScreen.navigationOptions = {
                  tabBarLabel: I18n.t('requests'),
                  tabBarIcon: ({ tintColor }) => <Icon name="mail" color={tintColor} />,
                };
                src/containers/search/SearchResultsPublicBodiesMasterScreen.js on lines 57..62

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    tableData.push({
                      label: I18n.t('foiRequestDetails.startedOn'),
                      value: <Text selectable>{moment(firstMessage).format('LLL')}</Text>,
                    });
                Severity: Major
                Found in src/components/screens/FoiRequestDetails/index.js and 2 other locations - About 1 hr to fix
                src/components/screens/FoiRequestDetails/index.js on lines 259..262
                src/components/screens/FoiRequestDetails/index.js on lines 265..268

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                SearchResultsPublicBodiesMasterScreen.navigationOptions = {
                  tabBarLabel: I18n.t('publicBodies'),
                  tabBarIcon: ({ tintColor }) => (
                    <Icon name="account-balance" color={tintColor} />
                  ),
                src/containers/search/SearchResultsFoiRequestsMasterScreen.js on lines 50..53

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        <ListItem
                          containerStyle={styles.listItemContainer}
                          title={I18n.t('moreScreen.aboutFOI')}
                          leftIcon={{ color: greyDark, name: 'info' }}
                          onPress={navigateToAboutFOIMaster}
                Severity: Major
                Found in src/containers/profile/ProfileStartScreen.js and 3 other locations - About 1 hr to fix
                src/containers/profile/ProfileStartScreen.js on lines 111..116
                src/containers/profile/ProfileStartScreen.js on lines 144..149
                src/containers/profile/ProfileStartScreen.js on lines 150..155

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        <ListItem
                          containerStyle={styles.listItemContainer}
                          title={I18n.t('moreScreen.feedback')}
                          leftIcon={{ color: greyDark, name: 'feedback' }}
                          onPress={navigateToFeedback}
                Severity: Major
                Found in src/containers/profile/ProfileStartScreen.js and 3 other locations - About 1 hr to fix
                src/containers/profile/ProfileStartScreen.js on lines 105..110
                src/containers/profile/ProfileStartScreen.js on lines 111..116
                src/containers/profile/ProfileStartScreen.js on lines 144..149

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    tableData.push({
                      label: I18n.t('foiRequestDetails.lastMessage'),
                      value: <Text selectable>{moment(lastMessage).format('LLL')}</Text>,
                    });
                Severity: Major
                Found in src/components/screens/FoiRequestDetails/index.js and 2 other locations - About 1 hr to fix
                src/components/screens/FoiRequestDetails/index.js on lines 254..257
                src/components/screens/FoiRequestDetails/index.js on lines 265..268

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        <ListItem
                          containerStyle={styles.listItemContainer}
                          title={I18n.t('moreScreen.faq')}
                          leftIcon={{ color: greyDark, name: 'question-answer' }}
                          onPress={navigateToFAQ}
                Severity: Major
                Found in src/containers/profile/ProfileStartScreen.js and 3 other locations - About 1 hr to fix
                src/containers/profile/ProfileStartScreen.js on lines 105..110
                src/containers/profile/ProfileStartScreen.js on lines 144..149
                src/containers/profile/ProfileStartScreen.js on lines 150..155

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      tableData.push({
                        label: I18n.t('foiRequestDetails.dueDate'),
                        value: <Text selectable>{moment(dueDate).format('LL')}</Text>,
                      });
                Severity: Major
                Found in src/components/screens/FoiRequestDetails/index.js and 2 other locations - About 1 hr to fix
                src/components/screens/FoiRequestDetails/index.js on lines 254..257
                src/components/screens/FoiRequestDetails/index.js on lines 259..262

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        <ListItem
                          containerStyle={styles.listItemContainer}
                          title={I18n.t('moreScreen.acknowledgements')}
                          leftIcon={{ color: greyDark, name: 'copyright' }}
                          onPress={navigateToAcknowledgements}
                Severity: Major
                Found in src/containers/profile/ProfileStartScreen.js and 3 other locations - About 1 hr to fix
                src/containers/profile/ProfileStartScreen.js on lines 105..110
                src/containers/profile/ProfileStartScreen.js on lines 111..116
                src/containers/profile/ProfileStartScreen.js on lines 150..155

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    Search: {
                      screen: SearchNavigator,
                      navigationOptions: {
                        tabBarIcon: ({ tintColor }) => (
                          <Icon size={24} color={tintColor} name="search" />
                Severity: Major
                Found in src/navigators/AppNavigator.js and 2 other locations - About 1 hr to fix
                src/navigators/AppNavigator.js on lines 44..51
                src/navigators/AppNavigator.js on lines 52..59

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    Profile: {
                      screen: ProfileNavigator,
                      navigationOptions: {
                        tabBarIcon: ({ tintColor }) => (
                          <Icon size={24} color={tintColor} name="more-horiz" />
                Severity: Major
                Found in src/navigators/AppNavigator.js and 2 other locations - About 1 hr to fix
                src/navigators/AppNavigator.js on lines 36..43
                src/navigators/AppNavigator.js on lines 44..51

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language