Sign upLogin

jfinkhaeuser/octiron

View on GitHub
Star

Showing 5 of 5 total issues

Method handlers_for has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def handlers_for(name, handler_class, write)
      # Defaults for the class
      @handlers[handler_class] ||= {}

      # Use prototype matching for Hash names
Severity: Minor
Found in lib/octiron/events/bus.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transmogrify has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def transmogrify(from, to, verify_results = true)
      # Get lookup keys
      from_name = from.class.to_s
      if from.is_a?(Hash)
        # Finding the correct from_name is tricky, because from is not a
Severity: Minor
Found in lib/octiron/transmogrifiers/registry.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transmogrify has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def transmogrify(from, to, verify_results = true)
      # Get lookup keys
      from_name = from.class.to_s
      if from.is_a?(Hash)
        # Finding the correct from_name is tricky, because from is not a
Severity: Minor
Found in lib/octiron/transmogrifiers/registry.rb - About 1 hr to fix

    Method handlers_for has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def handlers_for(name, handler_class, write)
      # Defaults for the class
      @handlers[handler_class] ||= {}

      # Use prototype matching for Hash names
    Severity: Minor
    Found in lib/octiron/events/bus.rb - About 1 hr to fix

      Method register has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def register(from, to, overwrite = false, transmogrifier_object = nil,
                 &transmogrifier_proc)
      Severity: Minor
      Found in lib/octiron/transmogrifiers/registry.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language