Sign upLogin

jfqd/redmine_helpdesk

View on GitHub
Star
lib/helpdesk_mailer.rb

Summary

Maintainability
C
1 day
Test Coverage

Method email_to_supportclient has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  def email_to_supportclient(issue, params)
    # issue, recipient, journal=nil, text='', copy_to=nil

    recipient = params[:recipient]
    journal = params[:journal]
Severity: Minor
Found in lib/helpdesk_mailer.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method email_to_supportclient has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def email_to_supportclient(issue, params)
    # issue, recipient, journal=nil, text='', copy_to=nil

    recipient = params[:recipient]
    journal = params[:journal]
Severity: Major
Found in lib/helpdesk_mailer.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        mail = if text.present? || reply.present?
      # sending out the journal note to the support client
      # or the first reply message
      t = text.present? ? "#{text}\n\n#{footer}" : reply
      body = expand_macros(t, issue, journal)
    Severity: Critical
    Found in lib/helpdesk_mailer.rb - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status