Sign upLogin

jhole89/orbital

View on GitHub
Star

Showing 31 of 31 total issues

Function createEntityHandler has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func createEntityHandler() (*handler.Handler, error) {

    entityType := graphql.NewObject(
        graphql.ObjectConfig{
            Name: "Entity",
Severity: Major
Found in app/api.go - About 2 hrs to fix

    Function createEntityHandler has 12 return statements (exceeds 4 allowed).
    Open

    func createEntityHandler() (*handler.Handler, error) {

    entityType := graphql.NewObject(
        graphql.ObjectConfig{
            Name: "Entity",
    Severity: Major
    Found in app/api.go - About 1 hr to fix

      exported type Config should have comment or be unexported
      Open

      type Config struct {
      Severity: Minor
      Found in app/config.go by golint

      exported method Gremlin.CreateEntity should have comment or be unexported
      Open

      func (g *Gremlin) CreateEntity(e *Entity) (*Entity, error) {
      Severity: Minor
      Found in app/database/gremlin.go by golint

      exported method Gremlin.CreateRelationship should have comment or be unexported
      Open

      func (g *Gremlin) CreateRelationship(r *Relationship) (*Relationship, error) {
      Severity: Minor
      Found in app/database/gremlin.go by golint

      exported method Gremlin.ListEntities should have comment or be unexported
      Open

      func (g *Gremlin) ListEntities() ([]*Entity, error) {
      Severity: Minor
      Found in app/database/gremlin.go by golint

      exported type Driver should have comment or be unexported
      Open

      type Driver interface {
      Severity: Minor
      Found in app/connectors/main.go by golint

      exported type ServiceConfig should have comment or be unexported
      Open

      type ServiceConfig struct {
      Severity: Minor
      Found in app/config.go by golint

      a blank import should be only in a main or test package, or have a comment justifying it
      Open

          _ "github.com/segmentio/go-athena"
      Severity: Minor
      Found in app/connectors/athena.go by golint

      2: cannot find package "github.com/etherlabsio/healthcheck/v2" in any of:
      Open

          "github.com/etherlabsio/healthcheck/v2"
      Severity: Minor
      Found in app/api.go by govet

      exported type AwsAthena should have comment or be unexported
      Open

      type AwsAthena struct {
      Severity: Minor
      Found in app/connectors/athena.go by golint

      exported method AwsAthena.Index should have comment or be unexported
      Open

      func (a *AwsAthena) Index() ([]*Node, error) {
      Severity: Minor
      Found in app/connectors/athena.go by golint

      if block ends with a return statement, so drop this else and outdent its block
      Open

          } else {
      Severity: Minor
      Found in app/connectors/main.go by golint

      exported type Column should have comment or be unexported
      Open

      type Column struct {
      Severity: Minor
      Found in app/connectors/athena.go by golint

      exported method Gremlin.GetRelationships should have comment or be unexported
      Open

      func (g *Gremlin) GetRelationships(id interface{}, context string) ([]*Entity, error) {
      Severity: Minor
      Found in app/database/gremlin.go by golint

      exported method AwsAthena.Query should have comment or be unexported
      Open

      func (a *AwsAthena) Query(queryString string) (*sql.Rows, error) {
      Severity: Minor
      Found in app/connectors/athena.go by golint

      exported method AwsAthena.Close should have comment or be unexported
      Open

      func (a *AwsAthena) Close() {
      Severity: Minor
      Found in app/connectors/athena.go by golint

      exported type Node should have comment or be unexported
      Open

      type Node struct {
      Severity: Minor
      Found in app/connectors/main.go by golint

      exported type AwsAthenaTableDetails should have comment or be unexported
      Open

      type AwsAthenaTableDetails struct {
      Severity: Minor
      Found in app/connectors/athena.go by golint

      if block ends with a return statement, so drop this else and outdent its block
      Open

          } else {
      Severity: Minor
      Found in app/database/graphs.go by golint
      Severity
      Category
      Status
      Source
      Language