Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Controller/Icl.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method actionImport has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function actionImport()
    {
        $is_waic_imported = Model\Setting::fetch('is_waic_imported');
        if ($is_waic_imported) Util::redirect(A11YC_URL);
Severity: Minor
Found in classes/Controller/Icl.php - About 1 hr to fix

    Function actionImport has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function actionImport()
    {
        $is_waic_imported = Model\Setting::fetch('is_waic_imported');
        if ($is_waic_imported) Util::redirect(A11YC_URL);
    Severity: Minor
    Found in classes/Controller/Icl.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function trashControl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function trashControl($act)
    {
        $id = intval(Input::get('id'));
        $item = Model\Icl::fetch($id);
        if (empty($item)) Util::error('Icl not found');
    Severity: Minor
    Found in classes/Controller/Icl.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using undefined variables such as '$fields' which will lead to PHP notices.
    Open

            return Model\Data::postfilter(Model\Icl::$fields[$type]);
    Severity: Minor
    Found in classes/Controller/Icl.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    There are no issues that match your filters.

    Category
    Status