Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Controller/PageAdd.php

Summary

Maintainability
C
1 day
Test Coverage

Function addPages has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public static function addPages($is_force = false, $pages = array())
    {
        $pages = $pages ?: explode("\n", trim(Input::post('pages')));

        // add without check
Severity: Minor
Found in classes/Controller/PageAdd.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addPages has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function addPages($is_force = false, $pages = array())
    {
        $pages = $pages ?: explode("\n", trim(Input::post('pages')));

        // add without check
Severity: Minor
Found in classes/Controller/PageAdd.php - About 2 hrs to fix

    Method getUrls has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function getUrls($url)
    {
        // fetch attributes
        $ua   = 'using';
        $html = Model\Html::fetch($url, $ua);
    Severity: Minor
    Found in classes/Controller/PageAdd.php - About 1 hr to fix

      Method echoGetUrls has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function echoGetUrls($url, $urls, $base_url)
    {
        // already added
        if (in_array($url, $urls))
        {
      Severity: Minor
      Found in classes/Controller/PageAdd.php - About 1 hr to fix

        Function getUrls has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function getUrls($url)
    {
        // fetch attributes
        $ua   = 'using';
        $html = Model\Html::fetch($url, $ua);
        Severity: Minor
        Found in classes/Controller/PageAdd.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in classes/Controller/PageAdd.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in classes/Controller/PageAdd.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in classes/Controller/PageAdd.php - About 30 mins to fix

              Function echoGetUrls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private static function echoGetUrls($url, $urls, $base_url)
    {
        // already added
        if (in_array($url, $urls))
        {
              Severity: Minor
              Found in classes/Controller/PageAdd.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status