Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Controller/ResultReport.php

Summary

Maintainability
A
1 hr
Test Coverage

Method report has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function report($base_url, $is_index = false)
    {
        $settings = Model\Setting::fetchAll();
        View::assign('title', A11YC_LANG_POLICY);
Severity: Minor
Found in classes/Controller/ResultReport.php - About 1 hr to fix

    Function report has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function report($base_url, $is_index = false)
    {
        $settings = Model\Setting::fetchAll();
        View::assign('title', A11YC_LANG_POLICY);
    Severity: Minor
    Found in classes/Controller/ResultReport.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused parameters such as '$is_index'.
    Open

        public static function report($base_url, $is_index = false)
    Severity: Minor
    Found in classes/Controller/ResultReport.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    There are no issues that match your filters.

    Category
    Status