Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Maintenance.php

Summary

Maintainability
A
1 hr
Test Coverage

Method isFisrtOfToday has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function isFisrtOfToday ()
    {
        if ( ! is_null(static::$is_first_of_day)) return static::$is_first_of_day;

        $today = date('Y-m-d');
Severity: Minor
Found in classes/Maintenance.php - About 1 hr to fix

    Function isFisrtOfToday has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isFisrtOfToday ()
    {
        if ( ! is_null(static::$is_first_of_day)) return static::$is_first_of_day;

        $today = date('Y-m-d');
    Severity: Minor
    Found in classes/Maintenance.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Remove error control operator '@' on line 102.
    Open

        public static function getLatestVersion ()
    {
        if ( ! self::isFisrtOfToday()) return false;
        if ( ! is_null(self::$latest_version)) return self::$latest_version;
    Severity: Minor
    Found in classes/Maintenance.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    There are no issues that match your filters.

    Category
    Status