Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Model/Issue.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function fetchByStatus has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public static function fetchByStatus($status, $force = false)
    {
        $vals = static::fetchAll($force);

        $retvals = array();
Severity: Minor
Found in classes/Model/Issue.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetch4Validation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function fetch4Validation($url, $html)
    {
        $vals = static::fetchAll();
        $html = empty($html) ? Element\Get\Each::firstTag(Element\Get::ignoredHtml($url)) : $html;
Severity: Minor
Found in classes/Model/Issue.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchAll has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function fetchAll($force = false)
    {
        if ( ! is_null(static::$vals) && ! $force) return static::$vals;
        $vals = array();
        $commons = array();
Severity: Minor
Found in classes/Model/Issue.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setCommonIssue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private static function setCommonIssue($issues, $commons)
    {
        foreach ($commons as $v)
        {
            foreach ($v as $vv)
Severity: Minor
Found in classes/Model/Issue.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetchAll has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function fetchAll($force = false)
    {
        if ( ! is_null(static::$vals) && ! $force) return static::$vals;
        $vals = array();
        $commons = array();
Severity: Minor
Found in classes/Model/Issue.php - About 1 hr to fix

    Function fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function fetch($id, $force = false)
    {
        $vals = static::fetchAll($force);
        foreach ($vals as $val)
        {
    Severity: Minor
    Found in classes/Model/Issue.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid assigning values to variables in if clauses and the like (line '94', column '10').
    Open

        private static function setCommonIssue($issues, $commons)
    {
        foreach ($commons as $v)
        {
            foreach ($v as $vv)
    Severity: Minor
    Found in classes/Model/Issue.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    There are no issues that match your filters.

    Category
    Status