jidaikobo-shibata/a11yc

View on GitHub
classes/Validate/Check/Fieldsetless.php

Summary

Maintainability
A
1 hr
Test Coverage

Function eliminateRadioCheckNames has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private static function eliminateRadioCheckNames($mms, $radio_check_names)
    {
        foreach ($mms as $mm)
        {
            $mm_mod = Element::ignoreElementsByStr($mm);
Severity: Minor
Found in classes/Validate/Check/Fieldsetless.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fieldsetless has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private static function fieldsetless($url, $ms, $radio_check_names)
    {
        foreach ($radio_check_names as $radio_check_name)
        {
            foreach ($ms as $k => $tstr)
Severity: Minor
Found in classes/Validate/Check/Fieldsetless.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using undefined variables such as '::$error_ids' which will lead to PHP notices.
Open

        static::addErrorToHtml($url, 'fieldsetless', static::$error_ids[$url], 'ignores');

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$error_ids' which will lead to PHP notices.
Open

        static::addErrorToHtml($url, 'legendless', static::$error_ids[$url], 'ignores');

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

There are no issues that match your filters.

Category
Status