Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Validate/Check/LinkCheck.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function check has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public static function check($url)
    {
        Validate\Set::log($url, 'link_check', self::$unspec, 5);
        if ( ! static::$do_link_check) return;
        Validate\Set::log($url, 'link_check', self::$unspec, 1);
Severity: Minor
Found in classes/Validate/Check/LinkCheck.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function check($url)
    {
        Validate\Set::log($url, 'link_check', self::$unspec, 5);
        if ( ! static::$do_link_check) return;
        Validate\Set::log($url, 'link_check', self::$unspec, 1);
Severity: Minor
Found in classes/Validate/Check/LinkCheck.php - About 1 hr to fix

    Function getTargetUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static function getTargetUrl($attrs)
    {
        if (isset($attrs['href']))
        {
            return $attrs['href'];
    Severity: Minor
    Found in classes/Validate/Check/LinkCheck.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return '';
    Severity: Major
    Found in classes/Validate/Check/LinkCheck.php - About 30 mins to fix

      Avoid using undefined variables such as '::$error_ids' which will lead to PHP notices.
      Open

                  static::addErrorToHtml($url, 'link_check', static::$error_ids[$url], 'ignores_comment_out');
      Severity: Minor
      Found in classes/Validate/Check/LinkCheck.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '::$error_ids' which will lead to PHP notices.
      Open

              if (isset(static::$error_ids[$url]))
      Severity: Minor
      Found in classes/Validate/Check/LinkCheck.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Remove error control operator '@' on line 81.
      Open

          public static function check($url)
    {
        Validate\Set::log($url, 'link_check', self::$unspec, 5);
        if ( ! static::$do_link_check) return;
        Validate\Set::log($url, 'link_check', self::$unspec, 1);
      Severity: Minor
      Found in classes/Validate/Check/LinkCheck.php by phpmd

      ErrorControlOperator

      Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

      Example

      function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

      Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

      There are no issues that match your filters.

      Category
      Status