Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Validate/Check/NotLabelButTitle.php

Summary

Maintainability
C
1 day
Test Coverage

Function setLabelAndElement has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private static function setLabelAndElement($ms)
    {
        $eles = array();
        $fors = array();
Severity: Minor
Found in classes/Validate/Check/NotLabelButTitle.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function check($url)
    {
        Validate\Set::log($url, 'not_label_but_title', self::$unspec, 1);
        $str = Element\Get::ignoredHtml($url);
        $ms = Element\Get::elementsByRe($str, 'ignores', 'tags');
Severity: Minor
Found in classes/Validate/Check/NotLabelButTitle.php - About 1 hr to fix

    Function setDeleteElement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function setDeleteElement($eles, $fors)
    {
        $del_eles = array();
        foreach ($fors as $for)
        {
    Severity: Minor
    Found in classes/Validate/Check/NotLabelButTitle.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setLabelAndElement has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function setLabelAndElement($ms)
    {
        $eles = array();
        $fors = array();
    Severity: Minor
    Found in classes/Validate/Check/NotLabelButTitle.php - About 1 hr to fix

      Function setSecondaryDeleteElement has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function setSecondaryDeleteElement($str, $eles)
    {
        $del_eles = array();
        $pattern = '/\<label[^\>]*?\>.*?\<\/label\>/is';
        preg_match_all($pattern, $str, $mms);
      Severity: Minor
      Found in classes/Validate/Check/NotLabelButTitle.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function check($url)
    {
        Validate\Set::log($url, 'not_label_but_title', self::$unspec, 1);
        $str = Element\Get::ignoredHtml($url);
        $ms = Element\Get::elementsByRe($str, 'ignores', 'tags');
      Severity: Minor
      Found in classes/Validate/Check/NotLabelButTitle.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setDeleteFor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function setDeleteFor($eles, $del_eles)
    {
        $del_fors = array();
        foreach (array_keys($del_eles) as $id)
        {
      Severity: Minor
      Found in classes/Validate/Check/NotLabelButTitle.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid using undefined variables such as '::$error_ids' which will lead to PHP notices.
      Open

              static::addErrorToHtml($url, 'not_label_but_title', static::$error_ids[$url], 'ignores');
      Severity: Minor
      Found in classes/Validate/Check/NotLabelButTitle.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (in_array($attrs['type'], array('text', 'checkbox', 'radio', 'file', 'password')))
                {
                    $eles[$k]['tag'] = $ms[0][$k];
                    $eles[$k]['tag_name'] = $ms[1][$k];
                    $eles[$k]['title'] = isset($attrs['title']) ? $attrs['title'] : '';
      Severity: Major
      Found in classes/Validate/Check/NotLabelButTitle.php and 1 other location - About 1 hr to fix
      classes/Validate/Check/NotLabelButTitle.php on lines 110..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  elseif (in_array($m, array('textarea', 'select')))
            {
                $eles[$k]['tag'] = $ms[0][$k];
                $eles[$k]['tag_name'] = $ms[1][$k];
                $eles[$k]['title'] = isset($attrs['title']) ? $attrs['title'] : '';
      Severity: Major
      Found in classes/Validate/Check/NotLabelButTitle.php and 1 other location - About 1 hr to fix
      classes/Validate/Check/NotLabelButTitle.php on lines 123..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status