Function getFields
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public static function getFields($table, $name = 'default')
{
if ( ! static::isTableExist($table, $name)) return array();
$instance = static::instance($name);
$retvals = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getFields
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function getFields($table, $name = 'default')
{
if ( ! static::isTableExist($table, $name)) return array();
$instance = static::instance($name);
$retvals = array();
Method __construct
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __construct($config)
{
$dbtype = strtolower($config['dbtype']);
$dbh = false;
Function isFieldsExist
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public static function isFieldsExist($table, $fields = array(), $name = 'default')
{
if ( ! static::isTableExist($table, $name)) return false;
$retvals = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function __construct
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function __construct($config)
{
$dbtype = strtolower($config['dbtype']);
$dbh = false;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '84', column '16'). Open
$dbh = new \PDO($dtbs, $config['user'], $config['password']);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '70', column '16'). Open
$dbh = new \PDO("sqlite:".$config['path']);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid classes with short names like Db. Configured minimum length is 3. Open
class Db
{
public $dbh;
protected $name;
protected $dbtype;
- Read upRead up
- Exclude checks
ShortClassName
Since: 2.9
Detects when classes or interfaces have a very short name.
Example
class Fo {
}
interface Fo {
}