Sign upLogin

jinzhu/gorm

View on GitHub
Star
callback_save.go

Summary

Maintainability
D
2 days
Test Coverage

Function saveAfterAssociationsCallback has a Cognitive Complexity of 106 (exceeds 20 allowed). Consider refactoring.
Open

func saveAfterAssociationsCallback(scope *Scope) {
    for _, field := range scope.Fields() {
        autoUpdate, autoCreate, saveReference, relationship := saveAssociationCheck(scope, field)

        if relationship != nil && (relationship.Kind == "has_one" || relationship.Kind == "has_many" || relationship.Kind == "many_to_many") {
Severity: Minor
Found in callback_save.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function saveBeforeAssociationsCallback has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func saveBeforeAssociationsCallback(scope *Scope) {
    for _, field := range scope.Fields() {
        autoUpdate, autoCreate, saveReference, relationship := saveAssociationCheck(scope, field)

        if relationship != nil && relationship.Kind == "belongs_to" {
Severity: Minor
Found in callback_save.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function saveAfterAssociationsCallback has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func saveAfterAssociationsCallback(scope *Scope) {
    for _, field := range scope.Fields() {
        autoUpdate, autoCreate, saveReference, relationship := saveAssociationCheck(scope, field)

        if relationship != nil && (relationship.Kind == "has_one" || relationship.Kind == "has_many" || relationship.Kind == "many_to_many") {
Severity: Minor
Found in callback_save.go - About 1 hr to fix

    Function saveAssociationCheck has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

    func saveAssociationCheck(scope *Scope, field *Field) (autoUpdate bool, autoCreate bool, saveReference bool, r *Relationship) {
    checkTruth := func(value interface{}) bool {
        if v, ok := value.(bool); ok && !v {
            return false
        }
    Severity: Minor
    Found in callback_save.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        } else if autoUpdate {
                        scope.Err(newDB.Save(elem).Error)
                    }
    Severity: Major
    Found in callback_save.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if f, ok := scope.FieldByName(associationForeignName); ok {
                                scope.Err(newScope.SetColumn(fieldName, f.Field.Interface()))
                            }
      Severity: Major
      Found in callback_save.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if autoCreate {
                            scope.Err(newDB.Save(elem).Error)
                        }
        Severity: Major
        Found in callback_save.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if relationship.JoinTableHandler == nil && len(relationship.ForeignFieldNames) != 0 {
                            for idx, fieldName := range relationship.ForeignFieldNames {
                                associationForeignName := relationship.AssociationForeignDBNames[idx]
                                if f, ok := scope.FieldByName(associationForeignName); ok {
                                    scope.Err(newScope.SetColumn(fieldName, f.Field.Interface()))
          Severity: Major
          Found in callback_save.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if relationship.PolymorphicType != "" {
                            scope.Err(newScope.SetColumn(relationship.PolymorphicType, relationship.PolymorphicValue))
                        }
            Severity: Major
            Found in callback_save.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if joinTableHandler := relationship.JoinTableHandler; joinTableHandler != nil {
                            scope.Err(joinTableHandler.Add(joinTableHandler, newDB, scope.Value, newScope.Value))
                        }
              Severity: Major
              Found in callback_save.go - About 45 mins to fix

                There are no issues that match your filters.

                Category
                Status