jjeremydiaz/OpenHouse

View on GitHub
config/routes.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [28/25]
Open

Rails.application.routes.draw do

  mount JasmineRails::Engine => '/specs' if defined?(JasmineRails)
  # The priority is based upon order of creation: first created -> highest priority.
  # See how all your routes lay out with "rake routes".
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Line is too long. [84/80]
Open

  # The priority is based upon order of creation: first created -> highest priority.
Severity: Minor
Found in config/routes.rb by rubocop

Trailing whitespace detected.
Open

  
Severity: Minor
Found in config/routes.rb by rubocop

Trailing whitespace detected.
Open

  
Severity: Minor
Found in config/routes.rb by rubocop

Trailing whitespace detected.
Open

  
Severity: Minor
Found in config/routes.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  get '/users/skip', to: 'users#skip', as: "skip"
Severity: Minor
Found in config/routes.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open

  
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [83/80]
Open

  #patch '/users/:id', to: 'users#update_house_picture', as: 'update_house_picture'
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [100/80]
Open

      post '/update_house_picture/:id', to: 'users#update_house_picture', as: 'update_house_picture'
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [106/80]
Open

      post '/update_profile_picture/:id', to: 'users#update_profile_picture', as: 'update_profile_picture'
Severity: Minor
Found in config/routes.rb by rubocop

Use the new Ruby 1.9 hash syntax.
Open

  resources :users, :except => [:edit]
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Trailing whitespace detected.
Open

  
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [83/80]
Open

  #patch '/users/:id', to: 'users#update_house_picture', as: 'update_house_picture'
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [81/80]
Open

  # Example resource route (maps HTTP verbs to controller actions automatically):
Severity: Minor
Found in config/routes.rb by rubocop

Extra empty line detected at block body beginning.
Open


  mount JasmineRails::Engine => '/specs' if defined?(JasmineRails)
Severity: Minor
Found in config/routes.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Missing space after #.
Open

  #patch '/users/:id', to: 'users#update_house_picture', as: 'update_house_picture'
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Use the new Ruby 1.9 hash syntax.
Open

  resources :users, :except => [:edit]
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Use the new Ruby 1.9 hash syntax.
Open

    resources :messages, :except => [:new]
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Trailing whitespace detected.
Open

  
Severity: Minor
Found in config/routes.rb by rubocop

Missing space after #.
Open

  #patch '/users/:id', to: 'users#update_house_picture', as: 'update_house_picture'
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Line is too long. [87/80]
Open

  patch '/users/new_billing/:id', to: 'users#update_billing', as: 'update_user_billing'
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [112/80]
Open

      post '/update_multiple_pictures/:id', to: 'users#update_multiple_pictures', as: 'update_multiple_pictures'
Severity: Minor
Found in config/routes.rb by rubocop

There are no issues that match your filters.

Category
Status