Sign upLogin

jjeremydiaz/OpenHouse

View on GitHub
Star
features/step_definitions/reserve_steps.rb

Summary

Maintainability
A
0 mins
Test Coverage

Final newline missing.
Open

end
Severity: Minor
Found in features/step_definitions/reserve_steps.rb by rubocop

Use 2 (not 4) spaces for indentation.
Open

        page.driver.browser.switch_to.alert.text.should eq("Your request has been sent.")
Severity: Minor
Found in features/step_definitions/reserve_steps.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [89/80]
Open

        page.driver.browser.switch_to.alert.text.should eq("Your request has been sent.")
Severity: Minor
Found in features/step_definitions/reserve_steps.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        page.driver.browser.switch_to.alert.text.should eq("Your request has been sent.")
Severity: Minor
Found in features/step_definitions/reserve_steps.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.
Open

Then /^I should see a reserve message$/ do
Severity: Minor
Found in features/step_definitions/reserve_steps.rb by rubocop

This cop checks for ambiguous regexp literals in the first argument of a method invocation without parentheses.

Example:

# bad

# This is interpreted as a method invocation with a regexp literal,
# but it could possibly be `/` method invocations.
# (i.e. `do_something./(pattern)./(i)`)
do_something /pattern/i

Example:

# good

# With parentheses, there's no ambiguity.
do_something(/pattern/i)

Use 2 (not 4) spaces for indentation.
Open

    if page.driver.class == Capybara::Selenium::Driver
Severity: Minor
Found in features/step_definitions/reserve_steps.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

There are no issues that match your filters.

Category
Status