Sign upLogin

jjsoft-ar/jjsoft-api

View on GitHub
Star
src/Exceptions/OAuthExceptionHandler.php

Summary

Maintainability
A
1 hr
Test Coverage

Method invalidRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function invalidRequest(OAuthException $e)
    {
        if($e instanceof InvalidRequestException){
            return Response::make([
                'errors' => [
Severity: Minor
Found in src/Exceptions/OAuthExceptionHandler.php - About 1 hr to fix

    Avoid using static access to class '\Response' in method 'invalidRequest'.
    Open

                return Response::make([
                'errors' => [
                    'status' => '400',
                    'code' => 'InvalidRefreshToken',
                    'title' => 'Invalid Refresh Token',
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Response' in method 'invalidRequest'.
    Open

                return Response::make([
                'errors' => [
                    'status' => '400',
                    'code' => 'InvalidRequest',
                    'title' => 'Invalid Request',
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Response' in method 'invalidCredentials'.
    Open

            return Response::make([
            'errors' => [
                'status' => '401',
                'code' => 'InvalidCredentials',
                'title' => 'Invalid Credentials',
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Response' in method 'invalidClient'.
    Open

            return Response::make([
            'errors' => [
                'status' => '401',
                'code' => 'InvalidClient',
                'title' => 'Invalid Client',
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$e'.
    Open

        protected function invalidCredentials(OAuthException $e)
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$e'.
    Open

        protected function invalidClient($e){
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

        public function handle(OAuthException $e)
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

        protected function invalidRequest(OAuthException $e)
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

        protected function invalidCredentials(OAuthException $e)
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

        protected function invalidClient($e){
    Severity: Minor
    Found in src/Exceptions/OAuthExceptionHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status