Sign upLogin

jjuliano/markdown-ui

View on GitHub
Star
components/collections/markdown-ui-menu/markdown-ui-menu.gemspec

Summary

Maintainability
Test Coverage

Add an empty line after magic comments.
Open

lib = File.expand_path('../lib', __FILE__)
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

%q-literals should be delimited by ( and ).
Open

  spec.summary       = %q{Responsive User Interfaces in Markdown}
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.description   = %q{Create responsive UI/UX for mobile and web using Markdown Syntax}
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency codeclimate-test-reporter should appear before simplecov.
Open

  spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.4'
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Final newline missing.
Open

end
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Line is too long. [91/80]
Open

  spec.description   = %q{Create responsive UI/UX for mobile and web using Markdown Syntax}
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Unnecessary utf-8 encoding comment.
Open

# coding: utf-8
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

%q-literals should be delimited by ( and ).
Open

  spec.description   = %q{Create responsive UI/UX for mobile and web using Markdown Syntax}
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency simplecov should appear before test-unit.
Open

  spec.add_development_dependency 'simplecov', '~> 0.10'
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Line is too long. [83/80]
Open

    raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.'
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

  if spec.respond_to?(:metadata)
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [104/80]
Open

  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.summary       = %q{Responsive User Interfaces in Markdown}
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency nokogiri should appear before redcarpet.
Open

  spec.add_dependency 'nokogiri', '~> 1.6'
Severity: Minor
Found in components/collections/markdown-ui-menu/markdown-ui-menu.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

There are no issues that match your filters.

Category
Status