jkawamoto/loci

View on GitHub
command/run.go

Summary

Maintainability
D
2 days
Test Coverage

Function run has a Cognitive Complexity of 74 (exceeds 20 allowed). Consider refactoring.
Open

func run(opt *RunOpt) (err error) {

    // Prepare to be canceled.
    ctx, cancel := context.WithCancel(context.Background())
    defer cancel()
Severity: Minor
Found in command/run.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has 193 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func run(opt *RunOpt) (err error) {

    // Prepare to be canceled.
    ctx, cancel := context.WithCancel(context.Background())
    defer cancel()
Severity: Major
Found in command/run.go - About 6 hrs to fix

    Function run has 19 return statements (exceeds 4 allowed).
    Open

    func run(opt *RunOpt) (err error) {
    
        // Prepare to be canceled.
        ctx, cancel := context.WithCancel(context.Background())
        defer cancel()
    Severity: Major
    Found in command/run.go - About 1 hr to fix

      error strings should not be capitalized or end with punctuation or a newline
      Open

                          fmt.Errorf("%v\n%v\n%v\n", msg, err.Error(), sec.String()))
      Severity: Minor
      Found in command/run.go by golint

      There are no issues that match your filters.

      Category
      Status