Sign upLogin

jkawamoto/loci

View on GitHub
Star
command/travis_python.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Travis.argumentSetPython has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Open

func (t *Travis) argumentSetPython(logger io.Writer) (res TestCaseSet, err error) {

    res = make(TestCaseSet)
    global := parseEnv(strings.Join(t.Env.Global, " "))
Severity: Minor
Found in command/travis_python.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseMatrixPython has 5 return statements (exceeds 4 allowed).
Open

func parseMatrixPython(v interface{}) (version string, c TestCase, err error) {

    m, ok := v.(map[interface{}]interface{})
    if !ok {
        err = fmt.Errorf("Given item is broken.")
Severity: Major
Found in command/travis_python.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for _, version := range t.Python {

        if len(t.Env.Matrix) == 0 {
            // If there is no matrix configuration, use only global configuration.
            res[version] = append(res[version], global)
    Severity: Minor
    Found in command/travis_python.go and 1 other location - About 45 mins to fix
    command/travis_go.go on lines 38..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    error strings should not be capitalized or end with punctuation or a newline
    Open

            err = fmt.Errorf("Env of the given item is broken.")
    Severity: Minor
    Found in command/travis_python.go by golint

    error strings should not be capitalized or end with punctuation or a newline
    Open

            err = fmt.Errorf("Given item is broken.")
    Severity: Minor
    Found in command/travis_python.go by golint

    There are no issues that match your filters.

    Category
    Status