Sign upLogin

jkawamoto/loci

View on GitHub
Star
command/travis_python_test.go

Summary

Maintainability
F
4 days
Test Coverage

Function TestPythonArgumentSet has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

func TestPythonArgumentSet(t *testing.T) {

    var (
        travis *Travis
        res    TestCaseSet
Severity: Minor
Found in command/travis_python_test.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestPythonArgumentSet has 120 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestPythonArgumentSet(t *testing.T) {

    var (
        travis *Travis
        res    TestCaseSet
Severity: Major
Found in command/travis_python_test.go - About 3 hrs to fix

    Function TestPythonOverwriteEvnSet has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
    Open

    func TestPythonOverwriteEvnSet(t *testing.T) {

    var err error
    // The following configuration is copied from matplotlib.
    travis, err := NewTravis([]byte(`language: "python"
    Severity: Minor
    Found in command/travis_python_test.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestPythonOverwriteEvnSet has 67 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestPythonOverwriteEvnSet(t *testing.T) {

    var err error
    // The following configuration is copied from matplotlib.
    travis, err := NewTravis([]byte(`language: "python"
    Severity: Minor
    Found in command/travis_python_test.go - About 1 hr to fix

      Function TestPythonArgumentSetWithFullDescriptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func TestPythonArgumentSetWithFullDescriptions(t *testing.T) {

    travis, err := storeAndLoadTravis(&Travis{
        Language: "python",
        Python:   []string{"2.7", "3.5"},
      Severity: Minor
      Found in command/travis_python_test.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func TestPythonArgumentSetWithFullDescriptions(t *testing.T) {

    travis, err := storeAndLoadTravis(&Travis{
        Language: "python",
        Python:   []string{"2.7", "3.5"},
      Severity: Major
      Found in command/travis_python_test.go and 1 other location - About 1 day to fix
      command/travis_go_test.go on lines 279..325

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 629.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func TestPythonMatrixExclude(t *testing.T) {

    var err error
    travis, err := NewTravis([]byte(`language: "python"
python:
      Severity: Major
      Found in command/travis_python_test.go and 1 other location - About 7 hrs to fix
      command/travis_go_test.go on lines 71..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 507.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func TestPythonMatrixInclude(t *testing.T) {

    var err error
    travis, err := storeAndLoadTravis(&Travis{
        Language: "python",
      Severity: Major
      Found in command/travis_python_test.go and 1 other location - About 6 hrs to fix
      command/travis_go_test.go on lines 23..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 431.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      //
      Severity: Minor
      Found in command/travis_python_test.go by gofmt

      There are no issues that match your filters.

      Category
      Status