Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/auth/device_authorizer.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function AuthorizeDeviceCode has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func AuthorizeDeviceCode(ctx context.Context, clientID string, output io.Writer) (token *adal.Token, err error) {

    code, err := GetDeviceCode(ctx, clientID)
    if err != nil {
        return
Severity: Minor
Found in cloud/azure/auth/device_authorizer.go - About 1 hr to fix

    Function AuthorizeDeviceCode has 6 return statements (exceeds 4 allowed).
    Open

    func AuthorizeDeviceCode(ctx context.Context, clientID string, output io.Writer) (token *adal.Token, err error) {

    code, err := GetDeviceCode(ctx, clientID)
    if err != nil {
        return
    Severity: Major
    Found in cloud/azure/auth/device_authorizer.go - About 40 mins to fix

      Function AuthorizeDeviceCode has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func AuthorizeDeviceCode(ctx context.Context, clientID string, output io.Writer) (token *adal.Token, err error) {

    code, err := GetDeviceCode(ctx, clientID)
    if err != nil {
        return
      Severity: Minor
      Found in cloud/azure/auth/device_authorizer.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status