Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/batch.go

Summary

Maintainability
D
2 days
Test Coverage

File batch.go has 661 lines of code (exceeds 500 allowed). Consider refactoring.
Open

//
// cloud/azure/batch.go
//
// Copyright (c) 2016-2017 Junpei Kawamoto
//
Severity: Minor
Found in cloud/azure/batch.go - About 5 hrs to fix

    Method BatchService.CreateJob has 117 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (s *BatchService) CreateJob(ctx context.Context, name string) (err error) {

    // 1. Check metadata, if error returns, it means no app exists, then upload.
    // 2. If version metadata is old or snapshot, upload new version.
    // 3. otherwise create url and use it.
    Severity: Major
    Found in cloud/azure/batch.go - About 3 hrs to fix

      Method BatchService.CreateTask has 91 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (s *BatchService) CreateTask(ctx context.Context, job string, task *script.Script) (err error) {

    var resourceFiles []*models.ResourceFile

    // Update source section.
      Severity: Major
      Found in cloud/azure/batch.go - About 2 hrs to fix

        Function NewBatchService has 67 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func NewBatchService(ctx context.Context, cfg *Config, logger *log.Logger) (service *BatchService, err error) {

    if logger == nil {
        logger = log.New(ioutil.Discard, "", log.LstdFlags)
    }
        Severity: Minor
        Found in cloud/azure/batch.go - About 1 hr to fix

          Method BatchService.CreateJob has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
          Open

          func (s *BatchService) CreateJob(ctx context.Context, name string) (err error) {

    // 1. Check metadata, if error returns, it means no app exists, then upload.
    // 2. If version metadata is old or snapshot, upload new version.
    // 3. otherwise create url and use it.
          Severity: Minor
          Found in cloud/azure/batch.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function NewBatchService has 9 return statements (exceeds 4 allowed).
          Open

          func NewBatchService(ctx context.Context, cfg *Config, logger *log.Logger) (service *BatchService, err error) {

    if logger == nil {
        logger = log.New(ioutil.Discard, "", log.LstdFlags)
    }
          Severity: Major
          Found in cloud/azure/batch.go - About 55 mins to fix

            Method BatchService.CreateTask has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
            Open

            func (s *BatchService) CreateTask(ctx context.Context, job string, task *script.Script) (err error) {

    var resourceFiles []*models.ResourceFile

    // Update source section.
            Severity: Minor
            Found in cloud/azure/batch.go - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method BatchService.CreateJob has 9 return statements (exceeds 4 allowed).
            Open

            func (s *BatchService) CreateJob(ctx context.Context, name string) (err error) {

    // 1. Check metadata, if error returns, it means no app exists, then upload.
    // 2. If version metadata is old or snapshot, upload new version.
    // 3. otherwise create url and use it.
            Severity: Major
            Found in cloud/azure/batch.go - About 55 mins to fix

              Method BatchService.CreateTask has 7 return statements (exceeds 4 allowed).
              Open

              func (s *BatchService) CreateTask(ctx context.Context, job string, task *script.Script) (err error) {

    var resourceFiles []*models.ResourceFile

    // Update source section.
              Severity: Major
              Found in cloud/azure/batch.go - About 45 mins to fix

                TODO found
                Open

                    // TODO: Delete related files, such as script, config, from the storage.
                Severity: Minor
                Found in cloud/azure/batch.go by fixme

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (s *BatchService) GetJobInfo(ctx context.Context, job string) (info *models.CloudJob, err error) {

    s.Logger.Println("Retrieving information of job", job)
    res, err := s.client.Jobs.JobGet(
        jobs.NewJobGetParamsWithContext(ctx).
                Severity: Major
                Found in cloud/azure/batch.go and 1 other location - About 1 hr to fix
                cloud/azure/batch.go on lines 326..343

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 183.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (s *BatchService) GetPoolInfo(ctx context.Context, name string) (info *models.CloudPool, err error) {

    s.Logger.Println("Retrieving information of pool", name)
    res, err := s.client.Pools.PoolGet(
        pools.NewPoolGetParamsWithContext(ctx).
                Severity: Major
                Found in cloud/azure/batch.go and 1 other location - About 1 hr to fix
                cloud/azure/batch.go on lines 650..667

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 183.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status