Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/batch_account_test.go

Summary

Maintainability
B
7 hrs
Test Coverage

Method mockBatchAcountServer.ServeHTTP has 90 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m *mockBatchAcountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
Severity: Major
Found in cloud/azure/batch_account_test.go - About 2 hrs to fix

    Method mockBatchAcountServer.ServeHTTP has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func (m *mockBatchAcountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
    Severity: Minor
    Found in cloud/azure/batch_account_test.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestBatchManagementService has 64 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestBatchManagementService(t *testing.T) {

    var err error
    testSubscriptionID := "00000000-0000-0000-0000-999999999999"
    testAccount := "test-account"
    Severity: Minor
    Found in cloud/azure/batch_account_test.go - About 1 hr to fix

      Method mockBatchAcountServer.ServeHTTP has 13 return statements (exceeds 4 allowed).
      Open

      func (m *mockBatchAcountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
      Severity: Major
      Found in cloud/azure/batch_account_test.go - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status