Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/log_manager.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method LogManager.get has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func (m *LogManager) get(ctx context.Context, urls []*url.URL, handler cloud.LogHandler) (err error) {

    ch := make(chan string)
    wg, ctx := errgroup.WithContext(ctx)
    reader, writer := io.Pipe()
Severity: Minor
Found in cloud/azure/log_manager.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method LogManager.Delete has 11 return statements (exceeds 4 allowed).
Open

func (m *LogManager) Delete(ctx context.Context, instanceName string) (err error) {

    var loc *url.URL
    // Delete a config file for initialization.
    loc, err = url.Parse(script.RoadieSchemePrefix + StartupContainer)
Severity: Major
Found in cloud/azure/log_manager.go - About 1 hr to fix

    Method LogManager.get has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (m *LogManager) get(ctx context.Context, urls []*url.URL, handler cloud.LogHandler) (err error) {

    ch := make(chan string)
    wg, ctx := errgroup.WithContext(ctx)
    reader, writer := io.Pipe()
    Severity: Minor
    Found in cloud/azure/log_manager.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status