jkawamoto/roadie

View on GitHub
cloud/azure/mock/storage.go

Summary

Maintainability
D
2 days
Test Coverage

Method StorageServer.ServeHTTP has a Cognitive Complexity of 81 (exceeds 20 allowed). Consider refactoring.
Open

func (s *StorageServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    var container, filename string
    if sp := strings.SplitN(strings.TrimPrefix(req.URL.Path, "/"), "/", 2); len(sp) == 1 {
        container = sp[0]
Severity: Minor
Found in cloud/azure/mock/storage.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method StorageServer.ServeHTTP has 170 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *StorageServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    var container, filename string
    if sp := strings.SplitN(strings.TrimPrefix(req.URL.Path, "/"), "/", 2); len(sp) == 1 {
        container = sp[0]
Severity: Major
Found in cloud/azure/mock/storage.go - About 5 hrs to fix

    Method StorageServer.ServeHTTP has 14 return statements (exceeds 4 allowed).
    Open

    func (s *StorageServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {
    
        var container, filename string
        if sp := strings.SplitN(strings.TrimPrefix(req.URL.Path, "/"), "/", 2); len(sp) == 1 {
            container = sp[0]
    Severity: Major
    Found in cloud/azure/mock/storage.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status