Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/resource/client/resources/resources_create_or_update_responses.go

Summary

Maintainability
D
1 day
Test Coverage

Method ResourcesCreateOrUpdateReader.ReadResponse has 6 return statements (exceeds 4 allowed).
Open

func (o *ResourcesCreateOrUpdateReader) ReadResponse(response runtime.ClientResponse, consumer runtime.Consumer) (interface{}, error) {
    switch response.Code() {

    case 200:
        result := NewResourcesCreateOrUpdateOK()
Severity: Major
Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go - About 40 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package resources

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
    Severity: Major
    Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go and 1 other location - About 1 day to fix
    cloud/azure/resource/client/resources/resources_create_or_update_by_id_responses.go on lines 1..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 857.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 3 places. Go fmt your code!
    Open

    package resources
    Severity: Minor
    Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go by gofmt

    type name will be used as resources.ResourcesCreateOrUpdateOK by other packages, and that stutters; consider calling this CreateOrUpdateOK
    Open

    type ResourcesCreateOrUpdateOK struct {
    Severity: Minor
    Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go by golint

    type name will be used as resources.ResourcesCreateOrUpdateAccepted by other packages, and that stutters; consider calling this CreateOrUpdateAccepted
    Open

    type ResourcesCreateOrUpdateAccepted struct {
    Severity: Minor
    Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go by golint

    type name will be used as resources.ResourcesCreateOrUpdateReader by other packages, and that stutters; consider calling this CreateOrUpdateReader
    Open

    type ResourcesCreateOrUpdateReader struct {
    Severity: Minor
    Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go by golint

    type name will be used as resources.ResourcesCreateOrUpdateCreated by other packages, and that stutters; consider calling this CreateOrUpdateCreated
    Open

    type ResourcesCreateOrUpdateCreated struct {
    Severity: Minor
    Found in cloud/azure/resource/client/resources/resources_create_or_update_responses.go by golint

    There are no issues that match your filters.

    Category
    Status