Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/resource/client/resources/resources_get_parameters.go

Summary

Maintainability
F
3 days
Test Coverage

ResourcesGetParams has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

type ResourcesGetParams struct {

    /*APIVersion
      The API version to use for the operation.
Severity: Minor
Found in cloud/azure/resource/client/resources/resources_get_parameters.go - About 2 hrs to fix

    Method ResourcesGetParams.WriteToRequest has 10 return statements (exceeds 4 allowed).
    Open

    func (o *ResourcesGetParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    if err := r.SetTimeout(o.timeout); err != nil {
        return err
    }
    Severity: Major
    Found in cloud/azure/resource/client/resources/resources_get_parameters.go - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      package resources

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
      Severity: Major
      Found in cloud/azure/resource/client/resources/resources_get_parameters.go and 2 other locations - About 3 days to fix
      cloud/azure/resource/client/resources/resources_check_existence_parameters.go on lines 1..265
      cloud/azure/resource/client/resources/resources_delete_parameters.go on lines 1..265

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1627.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      package resources
      Severity: Minor
      Found in cloud/azure/resource/client/resources/resources_get_parameters.go by gofmt

      type name will be used as resources.ResourcesGetParams by other packages, and that stutters; consider calling this GetParams
      Open

      type ResourcesGetParams struct {
      Severity: Minor
      Found in cloud/azure/resource/client/resources/resources_get_parameters.go by golint

      There are no issues that match your filters.

      Category
      Status