Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/azure/storage_test.go

Summary

Maintainability
F
3 days
Test Coverage

Function TestStorageService has a Cognitive Complexity of 82 (exceeds 20 allowed). Consider refactoring.
Open

func TestStorageService(t *testing.T) {

    var err error
    server := mock.NewStorageServer()
    defer server.Close()
Severity: Minor
Found in cloud/azure/storage_test.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestStorageService has 209 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestStorageService(t *testing.T) {

    var err error
    server := mock.NewStorageServer()
    defer server.Close()
Severity: Major
Found in cloud/azure/storage_test.go - About 7 hrs to fix

    Method mockStorageAccountServer.ServeHTTP has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
    Open

    func (m *mockStorageAccountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
    Severity: Minor
    Found in cloud/azure/storage_test.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mockStorageAccountServer.ServeHTTP has 107 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (m *mockStorageAccountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
    Severity: Major
    Found in cloud/azure/storage_test.go - About 3 hrs to fix

      Method mockStorageAccountServer.ServeHTTP has 17 return statements (exceeds 4 allowed).
      Open

      func (m *mockStorageAccountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
      Severity: Major
      Found in cloud/azure/storage_test.go - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status