Sign upLogin

jkawamoto/roadie

View on GitHub
Star
cloud/mock/log_test.go

Summary

Maintainability
D
1 day
Test Coverage

Function TestLogManagerGet has 140 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestLogManagerGet(t *testing.T) {

    now := time.Now()

    m := NewLogManager()
Severity: Major
Found in cloud/mock/log_test.go - About 4 hrs to fix

    Function TestLogManagerGet has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
    Open

    func TestLogManagerGet(t *testing.T) {

    now := time.Now()

    m := NewLogManager()
    Severity: Minor
    Found in cloud/mock/log_test.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestGetTaskLog has 55 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestGetTaskLog(t *testing.T) {

    m := NewLogManager()
    now := time.Now()
    queue := "test-queue"
    Severity: Minor
    Found in cloud/mock/log_test.go - About 1 hr to fix

      Function TestGetQueueLog has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestGetQueueLog(t *testing.T) {

    m := NewLogManager()
    now := time.Now()
    queue := "test-queue"
      Severity: Minor
      Found in cloud/mock/log_test.go - About 1 hr to fix

        Function TestLogMamagerDelete has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestLogMamagerDelete(t *testing.T) {

    now := time.Now()
    m := NewLogManager()
    m.Logs = map[string][]LogEntry{
        Severity: Minor
        Found in cloud/mock/log_test.go - About 1 hr to fix

          Function TestLogManagerGet has 8 return statements (exceeds 4 allowed).
          Open

          func TestLogManagerGet(t *testing.T) {

    now := time.Now()

    m := NewLogManager()
          Severity: Major
          Found in cloud/mock/log_test.go - About 50 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                m.QueueLogs = map[string][]LogEntry{
        queue: {
            {Time: now.Add(-30 * time.Minute), Body: "task-1: aaaa"},
            {Time: now.Add(1 * time.Minute), Body: "task-2: bbbb"},
            {Time: now.Add(25 * time.Minute), Body: "task-1: aaaa", Stderr: true},
            Severity: Minor
            Found in cloud/mock/log_test.go and 1 other location - About 45 mins to fix
            cloud/mock/log_test.go on lines 343..349

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                m.QueueLogs = map[string][]LogEntry{
        queue: {
            {Time: now.Add(-30 * time.Minute), Body: "task-1: aaaa"},
            {Time: now.Add(1 * time.Minute), Body: "task-2: bbbb"},
            {Time: now.Add(25 * time.Minute), Body: "task-1: aaaa", Stderr: true},
            Severity: Minor
            Found in cloud/mock/log_test.go and 1 other location - About 45 mins to fix
            cloud/mock/log_test.go on lines 280..286

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status